Add refactor of transolver model + darcy cfd example refresh.#1042
Merged
coreyjadams merged 9 commits intoNVIDIA:mainfrom Aug 6, 2025
Merged
Add refactor of transolver model + darcy cfd example refresh.#1042coreyjadams merged 9 commits intoNVIDIA:mainfrom
coreyjadams merged 9 commits intoNVIDIA:mainfrom
Conversation
Collaborator
Author
|
/blossom-ci |
peterdsharpe
approved these changes
Aug 6, 2025
Collaborator
peterdsharpe
left a comment
peterdsharpe
left a comment
There was a problem hiding this comment.
Nice job overall! A few naming things we should fix before merging, as well as just double-checking whether a numerically-meaningful change to the QKV-cache Linear layer was intended (if I'm understanding correctly how you've written it). I trust you to use your discretion about which of these changes to implement or not, and it's quite the good PR overall, so I'm pre-emptively approving so as not to be the bottleneck towards code freeze.
Collaborator
|
/blossom-ci |
Collaborator
Author
|
/blossom-ci |
Collaborator
Author
|
/blossom-ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see #1022
Description
Checklist
Dependencies