Merged
Conversation
renamed classes. 'str' control for attention. Updated docstring. Changed 'class' to 'condition'. Changed 'learnable' to 'positional'. Removed 'learn_sigma'
Dibyajyoti-Chakraborty
requested review from
CharlelieLrt,
coreyjadams and
pzharrington
coreyjadams
approved these changes
Aug 20, 2025
Collaborator
There was a problem hiding this comment.
Overall, I like this version of the DiT better: it is easy to follow, and I appreciate you using existing layers more instead of duplicating, that makes maintenance much easier.
I have two small comments about the try/except blocks in the imports. But once we resolve those, I think it's ready to go.
Collaborator
|
/blossom-ci |
CharlelieLrt
requested changes
Aug 20, 2025
Collaborator
CharlelieLrt
left a comment
CharlelieLrt
left a comment
There was a problem hiding this comment.
LGTM overall, greatly appreciate the fact that it's reusing many existing components. Juts a few minor comments about formatting, arguments validation, and documentation
Removed defaults for input_size and in_channels divided into layers.py and dit.py Added other validations
CharlelieLrt
approved these changes
Aug 20, 2025
Collaborator
|
/blossom-ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PhysicsNeMo Pull Request
Description
Diffusion Transformer (DiT) model. The DiT model can be accessed in
⚠️ Warning: - Experimental feature
physicsnemo.experimental.models.dit.DiT.subject to future API changes.
Checklist
Dependencies
timm, apex, tranformer_engine