Refactor #1258
Merged
Refactor #1258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No tests fixed yet.
phsyicsnemo.utils, launch.config is just gone. It was empty.
* Remove pyevtk * update dependency * update dimensions * ci issues
* Temporal interpolation training recipe * Add README * Docs changes based on comments * Update docstrings and README * Add temporal interpolation animation * Add animation link * Add shape check in loss * Updates of configs + trainer * Update config comments * Update README.md style guide edits * Added wandb logging Signed-off-by: Charlelie Laurent <claurent@nvidia.com> * Reformated sections in docstring for GeometricL2Loss Signed-off-by: Charlelie Laurent <claurent@nvidia.com> * Update README and configs * README changes + type hint fixes * Update README.md * Draft of validation script * Update validation and README * Fixed command in README.md for temporal_interpolation example Signed-off-by: Charlelie Laurent <claurent@nvidia.com> * Removed unused import in datapipe/climate_interp.py Signed-off-by: Charlelie Laurent <claurent@nvidia.com> * Updated license headers in temporal_interpolation example Signed-off-by: Charlelie Laurent <claurent@nvidia.com> * Renamed methods to avoid implicit shadowing in Trainer class Signed-off-by: Charlelie Laurent <claurent@nvidia.com> * Cosmetic changes in train.py and removed unused import in validate.py Signed-off-by: Charlelie Laurent <claurent@nvidia.com> * Added clamp in validate.py to make sure step does not go out of bounds Signed-off-by: Charlelie Laurent <claurent@nvidia.com> * Added the temporal_interpolation example to the docs + updated CHANGELOG.md Signed-off-by: Charlelie Laurent <claurent@nvidia.com> * Addressing remaining comments * Merged two data source classes in climate_interp.py Signed-off-by: Charlelie Laurent <claurent@nvidia.com> --------- Signed-off-by: Charlelie Laurent <claurent@nvidia.com> Co-authored-by: Charlelie Laurent <claurent@nvidia.com> Co-authored-by: megnvidia <mmiranda@nvidia.com> Co-authored-by: Charlelie Laurent <84199758+CharlelieLrt@users.noreply.github.com>
coreyjadams
requested review from
CharlelieLrt,
RishikeshRanade,
ktangsali,
megnvidia and
mnabian
as code owners
Contributor
|
Skipped: This PR changes more files than the configured file change limit: ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PhysicsNeMo Pull Request
Description
Checklist
Dependencies
Review Process
All PRs are reviewed by the PhysicsNeMo team before merging.
Depending on which files are changed, GitHub may automatically assign a maintainer for review.
We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.
AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.