Fix view and reshape ops when shape is passed as a kwarg.

[coreyjadams]

This essentially consolidates the argument parsing for all the operations.

PhysicsNeMo Pull Request

Description

Checklist

• I am familiar with the Contributing Guidelines.
• New or existing tests cover these changes.
• The documentation is up to date with these changes.
• The CHANGELOG.md is up to date with these changes.
• An issue is linked to this pull request.
• If I am implementing a new model or modifying any existing model, I have followed the Models Implementation Coding Standards.

Dependencies

Review Process

All PRs are reviewed by the PhysicsNeMo team before merging.

Depending on which files are changed, GitHub may automatically assign a maintainer for review.

We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.

AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.

[coreyjadams]

/blossom-ci

[greptile-apps]

Greptile Summary

This PR consolidates argument parsing for view and reshape operations to properly handle shape parameters passed as keyword arguments. The changes introduce a unified extract_view_and_reshape_arguments() function that handles all variations (positional, variadic, kwarg) for tensor.view(), tensor.reshape(), and torch.reshape().

Key changes:

• Refactored _extract_view_shape() into two functions: _reshape_args() for normalizing shape arguments and extract_view_and_reshape_arguments() for comprehensive argument extraction
• Added support for shape= kwarg in torch.reshape() and aten operations
• Added explicit error handling when shape is None or when dtype is incorrectly used with reshape
• Comprehensive test coverage for all argument variations (tuple, variadic, list, kwarg)

Issues found:

• Minor typo in comment: "remaning" should be "remaining" (line 708)

Important Files Changed

Filename	Overview
physicsnemo/domain_parallel/shard_utils/view_ops.py	Consolidated argument parsing for view/reshape operations to handle kwarg shapes correctly, with minor typo in comment
test/domain_parallel/ops/test_view_ops.py	Added comprehensive test coverage for all view/reshape argument variations including kwarg support

_{Last reviewed commit: f3f2d26}

[greptile-apps]

_{2 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[coreyjadams]

/blossom-ci