Skip to content

Bugfix with missing num_steps parameters in CorrDiff generate.py#1433

Merged
CharlelieLrt merged 4 commits intoNVIDIA:2.0.0-rcfrom
CharlelieLrt:2.0.0-rc
Feb 20, 2026
Merged

Bugfix with missing num_steps parameters in CorrDiff generate.py#1433
CharlelieLrt merged 4 commits intoNVIDIA:2.0.0-rcfrom
CharlelieLrt:2.0.0-rc

Conversation

@CharlelieLrt
Copy link
Collaborator

PhysicsNeMo Pull Request

Description

Checklist

Dependencies

Review Process

All PRs are reviewed by the PhysicsNeMo team before merging.

Depending on which files are changed, GitHub may automatically assign a maintainer for review.

We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.

AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.

Signed-off-by: Charlelie Laurent <claurent@nvidia.com>
@CharlelieLrt
Copy link
Collaborator Author

/blossom-ci

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 19, 2026

Greptile Summary

Adds missing num_steps parameter to stochastic sampler config and defensive defaults in code.

Changes:

  • Added num_steps: 18 to stochastic.yaml (matching the default in code)
  • Updated generate.py to use getattr() with fallback defaults (9 for deterministic, 18 for stochastic) to prevent crashes when num_steps is missing from config
  • Reorganized imports alphabetically in generate.py

Issues:

  • YAML comment indentation is incorrect (indented instead of at column 0)

Important Files Changed

Filename Overview
examples/weather/corrdiff/conf/base/generation/sampler/stochastic.yaml Added missing num_steps: 18 parameter with comment, but comment has incorrect indentation
examples/weather/corrdiff/generate.py Added getattr() with defaults to handle missing num_steps gracefully, imports reorganized alphabetically

Last reviewed commit: 3b43852

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Copy link
Collaborator

@coreyjadams coreyjadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CharlelieLrt
Copy link
Collaborator Author

/blossom-ci

CharlelieLrt and others added 2 commits February 19, 2026 16:56
…tic.yaml

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@CharlelieLrt
Copy link
Collaborator Author

/blossom-ci

@CharlelieLrt CharlelieLrt merged commit 91d89b7 into NVIDIA:2.0.0-rc Feb 20, 2026
1 check passed
ktangsali pushed a commit that referenced this pull request Feb 25, 2026
* Bugfix with num_steps parameters in CorrDiff generate.py

Signed-off-by: Charlelie Laurent <claurent@nvidia.com>

* Update examples/weather/corrdiff/conf/base/generation/sampler/stochastic.yaml

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

---------

Signed-off-by: Charlelie Laurent <claurent@nvidia.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants