test: loosening absolute tolerance for layer norm tests#1581
test: loosening absolute tolerance for layer norm tests#1581laserkelvin wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Signed-off-by: Kelvin Lee <kinlongkelvi@nvidia.com>
Greptile SummaryThis PR increases the absolute tolerance for Important Files Changed
|
|
/blossom-ci |
|
GLOBE related tests fail on GitHub CI - paging Dr. @peterdsharpe! |
|
@laserkelvin Aware of this, seems to be sporadically failing - apologies! Investigating here: #1580 |
PhysicsNeMo Pull Request
Description
This PR modifies the absolute numerical tolerance used to compare fused and unfused implementations of the equivariant layer norm, which triggers on certain platforms.
Checklist
Dependencies
N/A
Review Process
All PRs are reviewed by the PhysicsNeMo team before merging.
Depending on which files are changed, GitHub may automatically assign a maintainer for review.
We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.
AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.