Skip to content

Update cuml-cu13 version in requirements.txt#1659

Merged
ktangsali merged 1 commit into
2.1.0-rcfrom
domino-cuml-reqs
May 20, 2026
Merged

Update cuml-cu13 version in requirements.txt#1659
ktangsali merged 1 commit into
2.1.0-rcfrom
domino-cuml-reqs

Conversation

@ktangsali
Copy link
Copy Markdown
Collaborator

PhysicsNeMo Pull Request

Description

Checklist

Dependencies

Review Process

All PRs are reviewed by the PhysicsNeMo team before merging.

Depending on which files are changed, GitHub may automatically assign a maintainer for review.

We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.

AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 20, 2026

Greptile Summary

This PR bumps cuml-cu13 in the DoMINO example's requirements from the wildcard pin 25.10.* to the exact pin 26.2.0, and fixes a missing trailing newline. No other dependencies or code are touched.

  • Version bump: cuml-cu13==25.10.*26.2.0 (RAPIDS October 2025 → February 2026 release); the exact pin improves reproducibility but will no longer receive patch releases automatically.
  • Newline fix: Adds a missing newline at end of file.

Important Files Changed

Filename Overview
examples/cfd/external_aerodynamics/domino/requirements.txt Updates cuml-cu13 from the wildcard 25.10.* to the exact pin 26.2.0, and adds a trailing newline. No other dependencies are changed.

Reviews (1): Last reviewed commit: "Update cuml-cu13 version in requirements..." | Re-trigger Greptile

@ktangsali
Copy link
Copy Markdown
Collaborator Author

Re-opening a clean version of this: #1657

Copy link
Copy Markdown
Collaborator

@peterdsharpe peterdsharpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Probably nothing, but what's the diff at the EOF here? Carriage return vs. no? Newline at the bottom?

Image

@ktangsali ktangsali merged commit f36f82f into 2.1.0-rc May 20, 2026
1 of 2 checks passed
@ktangsali ktangsali deleted the domino-cuml-reqs branch May 20, 2026 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants