Skip to content

Add matplotlib and termcolor to requirements#1664

Merged
ktangsali merged 1 commit into
2.1.0-rcfrom
lagrangian-mgn-inference-deps
May 21, 2026
Merged

Add matplotlib and termcolor to requirements#1664
ktangsali merged 1 commit into
2.1.0-rcfrom
lagrangian-mgn-inference-deps

Conversation

@ktangsali
Copy link
Copy Markdown
Collaborator

PhysicsNeMo Pull Request

Description

Checklist

Dependencies

Review Process

All PRs are reviewed by the PhysicsNeMo team before merging.

Depending on which files are changed, GitHub may automatically assign a maintainer for review.

We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.

AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.

@ktangsali ktangsali requested a review from mnabian as a code owner May 21, 2026 17:10
@ktangsali ktangsali requested a review from abokov-nv May 21, 2026 17:10
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 21, 2026

Greptile Summary

This PR adds matplotlib and termcolor as explicit dependencies to the examples/cfd/lagrangian_mgn/requirements.txt file. Both packages were already being imported in the example code but were missing from the requirements list.

  • matplotlib is imported in inference.py (matplotlib.animation, matplotlib.pyplot) for generating visualizations.
  • termcolor is imported in loggers.py (termcolor.colored) for colored console output.

Important Files Changed

Filename Overview
examples/cfd/lagrangian_mgn/requirements.txt Adds missing matplotlib and termcolor dependencies; both are actively imported in inference.py and loggers.py respectively.

Reviews (1): Last reviewed commit: "Add tensorboard, matplotlib, and termcol..." | Re-trigger Greptile

@ktangsali ktangsali merged commit 7a84da6 into 2.1.0-rc May 21, 2026
1 of 2 checks passed
@ktangsali ktangsali deleted the lagrangian-mgn-inference-deps branch May 21, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants