Skip to content

np.infty -> np.inf#1668

Merged
ktangsali merged 1 commit into
NVIDIA:2.1.0-rcfrom
ktangsali:update-np-api
May 22, 2026
Merged

np.infty -> np.inf#1668
ktangsali merged 1 commit into
NVIDIA:2.1.0-rcfrom
ktangsali:update-np-api

Conversation

@ktangsali
Copy link
Copy Markdown
Collaborator

PhysicsNeMo Pull Request

Description

Checklist

Dependencies

Review Process

All PRs are reviewed by the PhysicsNeMo team before merging.

Depending on which files are changed, GitHub may automatically assign a maintainer for review.

We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.

AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 22, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ktangsali ktangsali requested a review from abokov-nv May 22, 2026 20:37
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 22, 2026

Greptile Summary

This PR replaces three deprecated NumPy constant aliases — np.infty and np.NINF — with their canonical equivalents np.inf and -np.inf, which were removed in NumPy 2.0.

  • generate_dataset.py: np.inftynp.inf (minv) and np.NINF-np.inf (maxv) in compute_statistics.
  • generate_graphs.py: np.inftynp.inf for pressure minimum initialization in add_field.
  • utils.py: -np.infty-np.inf for worst-error tracker initialization in write_checkpoint.

Important Files Changed

Filename Overview
examples/healthcare/bloodflow_1d_mgn/generate_dataset.py Replaces deprecated np.infty with np.inf and np.NINF with -np.inf for min/max initialization in compute_statistics
examples/healthcare/bloodflow_1d_mgn/generate_graphs.py Replaces deprecated np.infty with np.inf for pressure field minimum initialization in add_field
examples/weather/dlwp_healpix/utils.py Replaces deprecated -np.infty with -np.inf for worst_error initialization in write_checkpoint

Reviews (1): Last reviewed commit: "np.infty -> np.inf" | Re-trigger Greptile

@ktangsali ktangsali merged commit ce13d50 into NVIDIA:2.1.0-rc May 22, 2026
ktangsali added a commit that referenced this pull request May 27, 2026
ktangsali added a commit that referenced this pull request May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants