Skip to content

gnn recipes bug fixes#1672

Merged
ktangsali merged 2 commits into
2.1.0-rcfrom
gnn_recipes_bug_fixes
May 26, 2026
Merged

gnn recipes bug fixes#1672
ktangsali merged 2 commits into
2.1.0-rcfrom
gnn_recipes_bug_fixes

Conversation

@mnabian
Copy link
Copy Markdown
Collaborator

@mnabian mnabian commented May 26, 2026

PhysicsNeMo Pull Request

Description

Checklist

Dependencies

Review Process

All PRs are reviewed by the PhysicsNeMo team before merging.

Depending on which files are changed, GitHub may automatically assign a maintainer for review.

We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.

AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.

@mnabian mnabian requested a review from ktangsali May 26, 2026 21:56
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 26, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@mnabian mnabian self-assigned this May 26, 2026
@mnabian
Copy link
Copy Markdown
Collaborator Author

mnabian commented May 26, 2026

/blossom-ci

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 26, 2026

Greptile Summary

This PR makes bug fixes to GNN training recipes: the sintering-physics example removes TF GPU memory-growth configuration (aligned with switching to tensorflow-cpu), and the xaeronet example improves the PyG dependency installation instructions to auto-detect the user's torch/CUDA combination.

  • The sintering-physics train.py replaces native PyTorch AMP (torch.amp.GradScaler / torch.autocast) with NVIDIA Apex AMP, but Apex is not listed in requirements.txt and requires a custom CUDA-aware build — this will break fp16 training for users who haven't manually built Apex.
  • The xaeronet requirements.txt removes torch_scatter from pip-installable deps and moves it to a manual detection snippet in the README, and adds scikit-learn, tabulate, and matplotlib.
  • Five files are missing trailing newlines.

Important Files Changed

Filename Overview
examples/additive_manufacturing/sintering_physics/train.py Removes native PyTorch AMP and reverts to NVIDIA Apex; Apex is not in requirements and requires a custom build, so fp16 training will silently call exit() for most users. Also removes TF GPU memory-growth config and trailing newline.
examples/additive_manufacturing/sintering_physics/inference.py Removes TF GPU memory-growth configuration (appropriate since tensorflow-cpu is now specified) and drops the trailing newline.
examples/additive_manufacturing/sintering_physics/requirements.txt Adds tensorflow-cpu>=2.15,<3.0 to align with the cpu-only TF usage; reasonable change. Missing trailing newline.
examples/cfd/external_aerodynamics/xaeronet/README.md Installation instructions updated to auto-detect torch/CUDA versions for pyg-lib and torch_scatter; cleaner and more portable approach. Missing trailing newline.
examples/cfd/external_aerodynamics/xaeronet/requirements.txt Removes torch_scatter (now installed via manual detection step) and adds scikit-learn, tabulate, matplotlib. Missing trailing newline.

Reviews (1): Last reviewed commit: "gnn recipes bug fixes" | Re-trigger Greptile

Comment thread examples/additive_manufacturing/sintering_physics/train.py Outdated
Comment thread examples/additive_manufacturing/sintering_physics/train.py Outdated
@mnabian
Copy link
Copy Markdown
Collaborator Author

mnabian commented May 26, 2026

/blossom-ci

Copy link
Copy Markdown
Collaborator

@ktangsali ktangsali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ktangsali
Copy link
Copy Markdown
Collaborator

Linting is passing on this. Since this is an examples only change, pytest is not required. Merging it.

@ktangsali ktangsali merged commit 766e485 into 2.1.0-rc May 26, 2026
1 check was pending
@ktangsali ktangsali deleted the gnn_recipes_bug_fixes branch May 26, 2026 22:22
ktangsali pushed a commit that referenced this pull request May 27, 2026
* gnn recipes bug fixes

* minor fixes
ktangsali pushed a commit that referenced this pull request May 27, 2026
* gnn recipes bug fixes

* minor fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants