[WIP] Remove RAFT memory management#400
Merged
rapids-bot[bot] merged 12 commits intoMar 18, 2022
Merged
Conversation
rapids-bot Bot
pushed a commit
to rapidsai/cuml
that referenced
this pull request
Jan 18, 2022
Completes NVIDIA/raft#400 Authors: - Victor Lafargue (https://github.com/viclafargue) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: #4468
Contributor
|
@viclafargue, it looks like there's just a couple includes for |
Contributor
Author
|
Postponing to 22.04, as discussed offline. |
cjnolet
requested changes
Feb 14, 2022
| #include <raft/mr/buffer_base.hpp> | ||
| #include <raft/mr/device/buffer.hpp> | ||
|
|
||
| namespace raft { |
Contributor
There was a problem hiding this comment.
I believe this is going to require some updates to cugraph as well.
rapids-bot Bot
pushed a commit
to rapidsai/cugraph
that referenced
this pull request
Feb 15, 2022
Completes NVIDIA/raft#400 Authors: - Victor Lafargue (https://github.com/viclafargue) Approvers: - Chuck Hastings (https://github.com/ChuckHastings) URL: #2076
viclafargue
added
improvement
Contributor
|
rerun tests |
viclafargue
force-pushed
the
remove-raft-memory-management
branch
from
cf19910 to
0243630
Compare
cjnolet
reviewed
Mar 16, 2022
| /** Default cudaMallocHost/cudaFreeHost based host allocator */ | ||
| class default_allocator : public allocator { | ||
| public: | ||
| void* allocate(std::size_t n, cudaStream_t stream) override |
Contributor
There was a problem hiding this comment.
I had tried to remove this at one point and realized cugraph is still using it. We should also open a PR in cugraph to move the use of host allocator/buffer to something equivalent.
Contributor
There was a problem hiding this comment.
I just searched cugraph/cpp and could not find code calling this. We need to double check but we may have removed the code using this function.
Contributor
There was a problem hiding this comment.
@seunghwak I think you are right, I'm no longer seeing it in cugraph either.
cjnolet
approved these changes
Mar 18, 2022
Contributor
|
@gpucibot merge |
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
Completes NVIDIA/raft#400 Authors: - Victor Lafargue (https://github.com/viclafargue) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#4468
loulankxh
pushed a commit
to loulankxh/raft
that referenced
this pull request
Oct 14, 2025
Answers NVIDIA#308. Requires the appropriate changes in `cuML` and `cuGraph` before merging. Authors: - Victor Lafargue (https://github.com/viclafargue) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: NVIDIA#400
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Answers #308.
Requires the appropriate changes in
cuMLandcuGraphbefore merging.