[FIX] Link to cuco and add faiss EXCLUDE_FROM_ALL option#583
Merged
rapids-bot[bot] merged 5 commits intoMar 23, 2022
Conversation
trxcllnt
added
3 - Ready for Review
improvement
This was referenced Mar 23, 2022
Contributor
|
@gpucibot merge |
rapids-bot Bot
pushed a commit
to rapidsai/cuml
that referenced
this pull request
Mar 25, 2022
Depends on NVIDIA/raft#583 and https://github.com/rapidsai/cumlprims_mg/pull/86 This PR includes a few fixes to support source-only builds: 1. Use `CPMFindPackage` to get `cumlprims_mg` a. This enables building against a local `cumlprims_mg` build (`-D cumlprims_mg_ROOT=/cumlprims_mg/cpp/build`) 2. Explicitly call `find_package(Threads)` to be more resilient to RAFT changes Authors: - Paul Taylor (https://github.com/trxcllnt) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) - Robert Maynard (https://github.com/robertmaynard) URL: #4649
rapids-bot Bot
pushed a commit
to rapidsai/cugraph
that referenced
this pull request
Mar 27, 2022
Depends on NVIDIA/raft#583 and rapidsai/cugraph-ops#70 This PR uses `CPMFindPackage` to find (or build) `cugraph-ops`. This enables building from source against a local `cugraph-ops` build via `-D cugraph-ops_ROOT=/cugraph-ops/build`. Authors: - Paul Taylor (https://github.com/trxcllnt) Approvers: - Rick Ratzel (https://github.com/rlratzel) URL: #2148
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
Depends on NVIDIA/raft#583 and https://github.com/rapidsai/cumlprims_mg/pull/86 This PR includes a few fixes to support source-only builds: 1. Use `CPMFindPackage` to get `cumlprims_mg` a. This enables building against a local `cumlprims_mg` build (`-D cumlprims_mg_ROOT=/cumlprims_mg/cpp/build`) 2. Explicitly call `find_package(Threads)` to be more resilient to RAFT changes Authors: - Paul Taylor (https://github.com/trxcllnt) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) - Robert Maynard (https://github.com/robertmaynard) URL: rapidsai#4649
loulankxh
pushed a commit
to loulankxh/raft
that referenced
this pull request
Oct 14, 2025
This PR includes a few fixes to support source-only builds: 1. Defines linkage to `cuco::cuco` if the `RAFT_ENABLE_cuco_DEPENDENCY` variable is set, not if `cuco_ADDED` is true 2. Adds a flag to control the `EXCLUDE_FROM_ALL` for the faiss dependency. This flag can be off for conda builds, but true for C++-only source builds 3. Writes `version_config.hpp` header and fixes a potential GoogleBench issue Authors: - Paul Taylor (https://github.com/trxcllnt) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: NVIDIA#583
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes a few fixes to support source-only builds:
cuco::cucoif theRAFT_ENABLE_cuco_DEPENDENCYvariable is set, not ifcuco_ADDEDis trueEXCLUDE_FROM_ALLfor the faiss dependency. This flag can be off for conda builds, but true for C++-only source buildsversion_config.hppheader and fixes a potential GoogleBench issue