Skip to content

Add skill card generator skill#64

Closed
mohgupta-ship-it wants to merge 2 commits into
mainfrom
codex/add-skill-card-generator
Closed

Add skill card generator skill#64
mohgupta-ship-it wants to merge 2 commits into
mainfrom
codex/add-skill-card-generator

Conversation

@mohgupta-ship-it

Copy link
Copy Markdown
Member

Onboarding type

  • New product onboarding (new components.d/<slug>.yml file)
  • Other (catalog change, README fix, infrastructure, etc.)

For new product onboarding — author affirmations

By submitting this PR, I confirm on behalf of my team:

  • Skills cleared for open source release per NVIDIA's internal IP review process (six-question check, all answers affirmative)
  • License selected: Apache 2.0 / CC-BY 4.0 / Dual (Apache 2.0 + CC-BY 4.0). Specify: _____
  • No new license or new third-party component introduced beyond what the source repo already carries
  • Source repo is public and under an NVIDIA-owned GitHub org
  • .agents/skills/ or skills/ path used for new entries (or existing path retained for legacy entries per components.d/<slug>.yml)

NVIDIA contributors: see the internal onboarding guide for the IP review process details and license selection.

Reviewer checklist (OSS Skills PIC)

  • Author confirmations above are checked
  • components.d/<slug>.yml entry valid (required fields, unique catalog_dir, path exists in source repo, filename slug matches name)
  • SKILL.md frontmatter spec-compliant (at least one sampled)
  • No new license or third-party dependency requiring OSRB filing

All PRs

  • All commits signed off with DCO (git commit -s).
    If you forgot, run git rebase --signoff origin/main && git push --force-with-lease to retroactively sign all commits in your branch.

Other context (for non-onboarding PRs)

@mohgupta-ship-it

Copy link
Copy Markdown
Member Author

/nvskills-ci

11 similar comments
@mohgupta-ship-it

Copy link
Copy Markdown
Member Author

/nvskills-ci

@mohgupta-ship-it

Copy link
Copy Markdown
Member Author

/nvskills-ci

@mohgupta-ship-it

Copy link
Copy Markdown
Member Author

/nvskills-ci

@mohgupta-ship-it

Copy link
Copy Markdown
Member Author

/nvskills-ci

@mohgupta-ship-it

Copy link
Copy Markdown
Member Author

/nvskills-ci

@mohgupta-ship-it

Copy link
Copy Markdown
Member Author

/nvskills-ci

@mohgupta-ship-it

Copy link
Copy Markdown
Member Author

/nvskills-ci

@mohgupta-ship-it

Copy link
Copy Markdown
Member Author

/nvskills-ci

@mohgupta-ship-it

Copy link
Copy Markdown
Member Author

/nvskills-ci

@mohgupta-ship-it

Copy link
Copy Markdown
Member Author

/nvskills-ci

@mohgupta-ship-it

Copy link
Copy Markdown
Member Author

/nvskills-ci

@mohgupta-ship-it
mohgupta-ship-it force-pushed the codex/add-skill-card-generator branch from f46197f to e6fb2d1 Compare May 19, 2026 18:46
@mohgupta-ship-it

Copy link
Copy Markdown
Member Author

/nvskills-ci

@jasonnvidia

jasonnvidia commented May 20, 2026

Copy link
Copy Markdown
Collaborator

hi @mohgupta-ship-it
I just watched the Dev livestream (nice presentation!) and came across this PR looking for the tools.

I was a little confused if by the code... so had some Qs:

  1. is this a toolkit or an actual skill?
    Seems like most of the other skills in this folder are onboarded through components.d/xxxxx.yml sync from an upstream repo.

  2. is "model-card" name right here or should it be "skill-card"?
    nvidia-model-card-generation-toolkit

@mohgupta-ship-it

Copy link
Copy Markdown
Member Author

/nvskills-ci

@mosheabr

Copy link
Copy Markdown
Collaborator

Thanks Jason — both questions are right on. Catching up after the livestream:

On (1) toolkit vs skill / sync flow: You're correct that this isn't following our normal onboarding pattern. Every catalog skill should mirror from a product repo via components.d/<slug>.yml — pushing skill content directly into NVIDIA/skills creates an orphan (no upstream source of truth, the sync workflow can't refresh it). @mohgupta-ship-it, can you move the skill content to a proper source repo (e.g., NVIDIA/skill-card-generator or wherever it should live long-term) and onboard it via a components.d/skill-card-generator.yml registration like every other component? The .oms.sig you've already produced confirms the signing pipeline works end-to-end — we just need the source-side flow to match.

On (2) naming: Agree — model-card is wrong here. This generates Skill Cards (per-skill trust manifests), not model cards (Hugging Face / model-provenance concept). It conflates two distinct artifacts. Suggested rename:

  • Directory and catalog_dir: skill-card-generator (drop "model-card" and "toolkit")
  • Skill name in frontmatter: ai-ml-skill-card-generator (per the 5-prefix taxonomy landing this week — see docs/taxonomy.md)

Recommend we hold this PR and reopen as a proper components.d onboarding once the source repo is set up. Happy to walk through the flow on Slack if useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants