This repository was archived by the owner on Mar 21, 2024. It is now read-only.
Merged
Conversation
brycelelbach
added
to close: integrate
Collaborator
|
Integration task tracked by nvbug 2004663. |
Collaborator
|
Needs a test, too. |
Collaborator
|
@andrewcorrigan or @jaredhoberock, does one of you two want to volunteer to write a test for this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upon #859, this will resolve #725 and #850. The reproducers in each of those examples now compile, please let me know if any modifications are required.