Conversation
|
/ok-to-test 50e9703 |
Greptile SummaryThis PR migrates four Fern documentation GitHub Actions workflows from Two P1 issues from the previous review round remain unresolved in the current diff:
Confidence Score: 4/5Not safe to merge until the two unresolved P1 issues (empty PR context variables in preview-build and unguarded live publish trigger) are addressed. Two P1 findings from the prior review round are confirmed still present in the current file contents: the preview build workflow uses pull_request-only context variables under a push trigger (empty PR number breaks the comment workflow), and the publish workflow has no branch guard (any branch push to docs paths publishes live). .github/workflows/fern-docs-preview-build.yml (empty PR context variables) and .github/workflows/publish-fern-docs.yml (missing branch guard on push trigger) Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant GH as GitHub
participant BuildWF as Preview Build WF<br/>(push: pull-request/N)
participant CommentWF as Preview Comment WF<br/>(workflow_run)
participant PublishWF as Publish WF<br/>(push: any branch + paths / tag)
participant Fern as Fern Docs Site
Dev->>GH: push to pull-request/123 branch
GH->>BuildWF: trigger (docs/** or fern/** changed)
BuildWF->>BuildWF: Save PR metadata (pr_number="" ⚠️)
BuildWF->>GH: upload artifact fern-preview
GH->>CommentWF: trigger on workflow_run completed
CommentWF->>GH: download artifact
CommentWF->>Fern: fern generate --docs --preview --id HEAD_REF
CommentWF->>GH: post PR comment with preview URL
Dev->>GH: push to ANY branch touching docs/**
GH->>PublishWF: trigger ⚠️ (no branches filter)
PublishWF->>Fern: fern generate --docs (publishes live!)
Reviews (8): Last reviewed commit: "chore(github): update fern github action..." | Re-trigger Greptile |
|
/ok-to-test 6e9a0f4 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #268 +/- ##
=======================================
Coverage 68.46% 68.46%
=======================================
Files 82 82
Lines 4842 4842
=======================================
Hits 3315 3315
Misses 1395 1395
Partials 132 132 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dmitsh
force-pushed
the
ds-fern
branch
3 times, most recently
from
7978f4d to
b717f34
Compare
|
/ok-to-test b717f34 |
|
Small typo in The filter as written won't match changes to the workflow file itself. Two ways to fix:
|
|
/ok-to-test 90cae34 |
|
Want your agent to iterate on Greptile's feedback? Try greploops. |
|
/ok-to-test ba87bf8 |
|
/ok-to-test 996e5ca |
Signed-off-by: Dmitry Shmulevich <dshmulevich@nvidia.com>
PR #268 removed the `branches: [main]` push filter from `publish-fern-docs.yml` while keeping the `tags: [docs/v*]` filter. With GitHub Actions, defining `tags:` without a corresponding `branches:` restricts push events to tag refs only — branch pushes (including main) no longer trigger the workflow even when their changed paths match the `paths:` filter. Symptom: the live Fern site at https://topograph.docs.buildwithfern.com/topograph has not been republished since the manual workflow_dispatch on 2026-04-20T16:51Z. PRs #284, #289, #290, #291, and #292 all touched docs/ but produced zero workflow runs. The Reference section restored by #284 (and the clique-semantics clarifications added by #289) are on main but invisible on the published site. Restore `branches: [main]` so push events to main with docs/ or fern/ changes resume triggering publishes. Tag pushes for `docs/v*` and manual `workflow_dispatch` continue to work unchanged. To clear the backlog after this PR merges, dispatch the workflow manually one time: gh workflow run publish-fern-docs.yml --repo NVIDIA/topograph --ref main Signed-off-by: Rob Esker <resker@nvidia.com>
2 participants
No description provided.