fix(ci): restore branches filter on Fern publish push trigger#304
Merged
Conversation
PR NVIDIA#268 removed the `branches: [main]` push filter from `publish-fern-docs.yml` while keeping the `tags: [docs/v*]` filter. With GitHub Actions, defining `tags:` without a corresponding `branches:` restricts push events to tag refs only — branch pushes (including main) no longer trigger the workflow even when their changed paths match the `paths:` filter. Symptom: the live Fern site at https://topograph.docs.buildwithfern.com/topograph has not been republished since the manual workflow_dispatch on 2026-04-20T16:51Z. PRs NVIDIA#284, NVIDIA#289, NVIDIA#290, NVIDIA#291, and NVIDIA#292 all touched docs/ but produced zero workflow runs. The Reference section restored by NVIDIA#284 (and the clique-semantics clarifications added by NVIDIA#289) are on main but invisible on the published site. Restore `branches: [main]` so push events to main with docs/ or fern/ changes resume triggering publishes. Tag pushes for `docs/v*` and manual `workflow_dispatch` continue to work unchanged. To clear the backlog after this PR merges, dispatch the workflow manually one time: gh workflow run publish-fern-docs.yml --repo NVIDIA/topograph --ref main Signed-off-by: Rob Esker <resker@nvidia.com>
Contributor
Greptile SummaryThis PR restores the missing Confidence Score: 5/5Safe to merge — minimal two-line restoration of a pre-existing, correct configuration. No logic, security, or functional issues. The change precisely restores the intended trigger behavior and the rest of the workflow is unchanged. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Push event] --> B{Trigger filter}
B -->|branch == main AND paths match docs/** or fern/**| C[Workflow fires ✅]
B -->|tag matches docs/v*| C
B -->|branch != main OR paths don't match| D[Workflow skipped]
E[workflow_dispatch] --> C
style C fill:#22c55e,color:#fff
style D fill:#ef4444,color:#fff
Reviews (1): Last reviewed commit: "fix(ci): restore branches filter on Fern..." | Re-trigger Greptile |
dmitsh
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR #268 removed the
branches: [main]push filter from.github/workflows/publish-fern-docs.ymlwhile keeping thetags: [docs/v*]filter. With GitHub Actions, definingtags:without a correspondingbranches:restricts push events to tag refs only — branch pushes (includingmain) no longer trigger the workflow even when their changed paths match thepaths:filter.Symptom: the live Fern site at https://topograph.docs.buildwithfern.com/topograph has not been republished since the manual
workflow_dispatchon 2026-04-20T16:51Z. PRs #284, #289, #290, #291, and #292 all toucheddocs/but produced zero workflow runs. The Reference section restored by #284 (and the clique-semantics clarifications added by #289) are on main but invisible on the published site.Fix: restore
branches: [main]so push events to main withdocs/orfern/changes resume triggering publishes. Tag pushes fordocs/v*and manualworkflow_dispatchcontinue to work unchanged.Verification
After this merges, the workflow should fire automatically on the next docs-touching push to main. To clear the existing backlog (#284 → #292) immediately, run once:
Doc Impact
None — this is a CI-config fix; no doc surfaces (per AGENTS.md Documentation Impact Evaluation table).
Checklist
make qualifynot applicable (workflow YAML only)