Skip to content

fix(ci): restore branches filter on Fern publish push trigger#304

Merged
dmitsh merged 1 commit into
NVIDIA:mainfrom
resker:fix/fern-publish-branches-trigger
Apr 29, 2026
Merged

fix(ci): restore branches filter on Fern publish push trigger#304
dmitsh merged 1 commit into
NVIDIA:mainfrom
resker:fix/fern-publish-branches-trigger

Conversation

@resker
Copy link
Copy Markdown
Collaborator

@resker resker commented Apr 29, 2026

Description

PR #268 removed the branches: [main] push filter from .github/workflows/publish-fern-docs.yml while keeping the tags: [docs/v*] filter. With GitHub Actions, defining tags: without a corresponding branches: restricts push events to tag refs only — branch pushes (including main) no longer trigger the workflow even when their changed paths match the paths: filter.

Symptom: the live Fern site at https://topograph.docs.buildwithfern.com/topograph has not been republished since the manual workflow_dispatch on 2026-04-20T16:51Z. PRs #284, #289, #290, #291, and #292 all touched docs/ but produced zero workflow runs. The Reference section restored by #284 (and the clique-semantics clarifications added by #289) are on main but invisible on the published site.

Fix: restore branches: [main] so push events to main with docs/ or fern/ changes resume triggering publishes. Tag pushes for docs/v* and manual workflow_dispatch continue to work unchanged.

Verification

After this merges, the workflow should fire automatically on the next docs-touching push to main. To clear the existing backlog (#284#292) immediately, run once:

gh workflow run publish-fern-docs.yml --repo NVIDIA/topograph --ref main

Doc Impact

None — this is a CI-config fix; no doc surfaces (per AGENTS.md Documentation Impact Evaluation table).

Checklist

  • make qualify not applicable (workflow YAML only)
  • Documentation impact evaluated — none
  • DCO sign-off present

PR NVIDIA#268 removed the `branches: [main]` push filter from
`publish-fern-docs.yml` while keeping the `tags: [docs/v*]` filter. With
GitHub Actions, defining `tags:` without a corresponding `branches:`
restricts push events to tag refs only — branch pushes (including main)
no longer trigger the workflow even when their changed paths match the
`paths:` filter.

Symptom: the live Fern site at
https://topograph.docs.buildwithfern.com/topograph has not been
republished since the manual workflow_dispatch on 2026-04-20T16:51Z.
PRs NVIDIA#284, NVIDIA#289, NVIDIA#290, NVIDIA#291, and NVIDIA#292 all touched docs/ but produced
zero workflow runs. The Reference section restored by NVIDIA#284 (and the
clique-semantics clarifications added by NVIDIA#289) are on main but invisible
on the published site.

Restore `branches: [main]` so push events to main with docs/ or fern/
changes resume triggering publishes. Tag pushes for `docs/v*` and manual
`workflow_dispatch` continue to work unchanged.

To clear the backlog after this PR merges, dispatch the workflow
manually one time:

  gh workflow run publish-fern-docs.yml --repo NVIDIA/topograph --ref main

Signed-off-by: Rob Esker <resker@nvidia.com>
@resker resker requested a review from dmitsh as a code owner April 29, 2026 20:06
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 29, 2026

Greptile Summary

This PR restores the missing branches: [main] filter to the push trigger in publish-fern-docs.yml, which was accidentally dropped in PR #268. Without it, GitHub Actions only fires on docs/v* tag pushes, silently skipping all branch pushes — explaining why five doc-touching PRs produced no workflow runs. The fix is correct and minimal.

Confidence Score: 5/5

Safe to merge — minimal two-line restoration of a pre-existing, correct configuration.

No logic, security, or functional issues. The change precisely restores the intended trigger behavior and the rest of the workflow is unchanged.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/publish-fern-docs.yml Restores branches: [main] to the push trigger, fixing the regression from PR #268 where tag-only filter silently suppressed branch pushes.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Push event] --> B{Trigger filter}
    B -->|branch == main AND paths match docs/** or fern/**| C[Workflow fires ✅]
    B -->|tag matches docs/v*| C
    B -->|branch != main OR paths don't match| D[Workflow skipped]
    E[workflow_dispatch] --> C
    
    style C fill:#22c55e,color:#fff
    style D fill:#ef4444,color:#fff
Loading

Reviews (1): Last reviewed commit: "fix(ci): restore branches filter on Fern..." | Re-trigger Greptile

@dmitsh dmitsh merged commit 8587856 into NVIDIA:main Apr 29, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants