Events - fix table error & desktop nav z-index #716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchlfryn
force-pushed
the
events-snafus
branch
from
0d6e11b to
521d370
Compare
|
Preview deployment: https://events-snafus.preview.avy-fx.org |
rchlfryn
changed the title
rchlfryn
changed the title
busbyk
reviewed
Nov 25, 2025
Collaborator
busbyk
left a comment
busbyk
left a comment
There was a problem hiding this comment.
Looks good. Just a few comments.
Last we chatted, we'd talked about just using tags for affinity groups for events and centers could add them or not. But it's nice that centers won't have to add these manually / it encourages them to use these ones specifically so I like this addition.
| params.append('types', filterByEventTypes.join(',')) | ||
| if (filterByEventGroups?.length) { | ||
| const groupIds = filterByEventGroups | ||
| .map((g) => (typeof g === 'object' ? g.id : g)) |
Collaborator
There was a problem hiding this comment.
This might be a nice utility function at some point -- like get id from value that might be a document object or a number which is the id. Just an aside.
rchlfryn
changed the title
busbyk
requested changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Key Changes
z-indexto desktop navMigration Explanation
Just added to
eventsbranch migration