-
Notifications
You must be signed in to change notification settings - Fork 1
Add weather forecast page #773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Preview deployment: https://weather-forecast-page.preview.avy-fx.org |
busbyk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also add this page to the built-in pages list? https://github.com/NWACus/web/blob/main/docs/onboarding.md#L19
I didn't add the single observation and single avalanche pages there because they're dynamic so it doesn't really apply but this one does.
| export type WidgetPageWithRouterKey = | ||
| | 'forecasts' | ||
| | 'forecast-zone' | ||
| | 'weather-forecasts' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⛏️ Do we want to use weather-forecast (singular) to match the title of the page? (= A wicked nitpick)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forecasts was plural so I blindly followed it. I will update it since it mades sense as a singular forecast.
src/app/(frontend)/[center]/weather/forecast/opengraph-image.tsx
Outdated
Show resolved
Hide resolved
@busbyk I intentionally left this page out since not every Avy center has a weather forecast page. Thoughts? |
Ah I hear ya. Maybe makes sense to include it in that list with a caveat that not every center should get it - that it should be based on the capabilities API. I just think that's the only place we have built-in pages documented so including all options there for when we have to create them manually seems helpful. |
Description
Adds weather forecast page using the forecast NAC widget.
Related Issues
Fixes #734
Key Changes
/weather/forecastwhich loads theforecastwidget and loadsweathersection using the capabilities APIScreenshots / Demo
SNFAC
weather: trueNWAC
weather: falseFuture enhancements / Questions
Do we like this approach?