Conversation
Contributor
|
Preview deployment: https://fix-validations.preview.avy-fx.org |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bug stemming from #895 . Since block are truly validating now, our external link validation was incorrectly erroring our for
mailto:links. This PR update the validation to includemailto,tel, andsmsRelated Issues
Fixes #924
How to test
Tested locally by recreating content on the page mentioned form prod in #924
Screenshots / Demo video
https://www.loom.com/share/eec0de40fe7c4240b17940c9e0c0e23d
Migration Explanation
Future enhancements / Questions
We should include this in a test