SCC-5452: NYQL test foundation + first precision group (exact + identifier)#767
Conversation
samanthaandrews
left a comment
There was a problem hiding this comment.
Chris, this is great work. So much easier to review and really demonstrates your ability to break down the work into small pieces.
What's improved:
- Linting is enabled which makes all of the code conform to the rest of the repo standards. There's no unused expressions or little things that we need to clean up in the PR because the linter took care of those warnings. Awesome.
- baseUrl is in an env var with QA url as the default defined in helpers.js so we don't have to repeat it throughout the tests.
- No stray console.logs or commented out blocks. The code is easy to read so the comments just aren't necessary, which is great.
- Explicitly explaining in the PR description that you'll make the CI changes in PR 2
I just have a few small suggested changes that should be easy to accommodate. Feel free to re-request review from me when you're ready.
| // These are some tests to verify that certain NYQL queries are returning results with the expected precision, especially for fields like call numbers where we want to ensure that the query is matching the intended values and not over- or under-matching. | ||
|
|
||
| describe('Discovery API - NYQL precision tests', function () { | ||
| this.timeout(30000) |
There was a problem hiding this comment.
Let's import and use the TIMEOUT from helpers.js here
samanthaandrews
left a comment
There was a problem hiding this comment.
Looks good on my end. Go ahead and request review from @danamansana and optionally @nonword and @charmingduchess . For context, Chris is breaking down the NYQL api test PRs into smaller pieces. The intention with this foundational PR is to merge it into main and add the rest of the test PRs on top of it (there may be 6+). They should all be pretty small and easy to review.
danamansana
left a comment
There was a problem hiding this comment.
Looks like a good start!
Summary
This PR adds the NYQL integration test foundation and first precision test group for PR 1.
Includes
Validation
Scope Note