[UI] Allow disabling image transitions - #89
Merged
Conversation
Keep cross-dissolves enabled by default while allowing clients with extended-range content to replace images without alpha blending.
NachoSoto
marked this pull request as ready for review
September 3, 2026 04:00
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
NachoSoto
added a commit
that referenced
this pull request
Sep 3, 2026
## Summary - revert #89 now that WatchChess PR #1157 replaces the reused UIKit tournament cells with SwiftUI - remove the unused `animatesImageChanges` API and its opt-out test - restore `master` to the pre-#89 image-transition behavior ## Validation - Swift 6 iOS simulator library build passed - `CacheRendererTests.failedInflationIsNotCached` passed in isolation - strict SwiftLint passed with zero violations - the full suite reproduced its documented pre-existing suite-order failure in `CacheRendererTests.failedInflationIsNotCached`; this is the same baseline failure recorded on #89 and is unrelated to the revert ## Dependency cleanup The WatchChess HDR stack no longer pins #89. Its gradient now lives directly in the SwiftUI tournament cell, and the old UIKit cell cross-dissolve path no longer exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Cross-dissolving extended-range tournament backgrounds over their placeholders produces a washed-out double exposure during scrolling:
Validation
AsyncImageViewBehaviorTestspassed, including the new animation opt-out coverageCacheRendererTests.failedInflationIsNotCachedpassed when run aloneCacheRendererTests.failedInflationIsNotCached; the same failure reproduces from the unchanged base commitd0366ccd, confirming it is pre-existing and unrelated to this changexcodebuildstill exited 65 on that same baseline failure