[Rendering] Share remote image download pipeline - #91
Merged
Conversation
Add a generic raw-data decoder renderer and make RemoteImageRenderer delegate to it. Clients that need custom image decoding or encoded cache payloads can now reuse the established HTTP status and error behavior.
NachoSoto
marked this pull request as ready for review
September 3, 2026 16:23
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RemoteImageDataRendererfor downloading image bytes into a customRenderResultTypeRemoteImageRendererErrorbehavior in one implementationRemoteImageRendererdelegate to the generic renderer without changing its public behaviorMotivation
WatchChess HDR backgrounds need
UIImageReaderdecoding and must retain the original HEIC bytes for disk caching. This API lets that client reuse AsyncImageView's transport/error pipeline instead of duplicating it.Validation
swiftlint --config .swiftlint.yml --strict