chore(benchmarks): trim ~297 MB of all-zero samples arrays (no bloat) - #79
Merged
Conversation
This was referenced Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
For each
benchmarks/results/2026-06-14/fedora/<class>/psi-{cpu,io}.json(10 files):samplestonull(was 4.4M–4.5M all-zero entries; no analytic value)metablock documenting the trim (samples_trimmed_at,samples_trimmed_reason,original_samples_len)power_source,counter,avg_watts,median,p95,iqr,anomalies,class_*Why
Each psi record carries ~30 MB of all-zero
samplesarrays (4.4M–4.5M entries × 0). Summary stats (median/p95/iqr) already capture the same information. HUMAN decision 2026-06-15: yes-trim, no-bloat.Size impact
311 MB → ~12 KB across 10 psi records (99.96% reduction).
Out of scope
All-zero
samplessampler bug — separate follow-up issue (caution #3 of WP-ENERGY-PROBE verdict). Investigating why the sampler writes zeros belongs in its own PR with proper repro onvictus.ENERGY gate (SPEC §6)
Closure is unchanged — energy evidence is in
power_source/energyfields, not insamples. PR #75 (f60789d) merge is the gate-clear event; this PR is housekeeping only.Refs: WP-ENERGY-PROBE verdict caveats #2 (bloat) + #3 (sampler bug).