perf(scheduler): avoid unnecessary db roundtrip on task retirement#6810
Merged
ErickRDev merged 2 commits intoJul 21, 2026
Merged
Conversation
Actions, webhooks and on-event handlers are not scheduled and thus have no schedule id, so attempting to compute the schedule's `next_execution_at` timestamp is a no-op as the `UPDATE` `WHERE` clause will never match a tuple on this code path. This PR simply adds a runtime check to validate whether the task has a schedule id before calling `scheduleNextExecution`, thus avoiding the no-op query for non-syncs.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
ErickRDev
changed the title
ErickRDev
marked this pull request as ready for review
July 17, 2026 20:55
pfreixes
approved these changes
Jul 20, 2026
pfreixes
reviewed
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actions, webhooks and on-event handlers are not scheduled and thus have no schedule id, so attempting to compute the schedule's
next_execution_attimestamp is a no-op: theUPDATE'sWHEREclause will never match a tuple for non-sync functions. This PR simply adds a runtime check to validate whether the task has a schedule id before callingscheduleNextExecution, thus avoiding the extra roundtrip incurred by the no-op query.