fix(webapp): show usage on the 1st of the month - #7323
Merged
macko911 merged 2 commits intoSep 1, 2026
Merged
Conversation
Connections and Sync records are running-average metrics, drawn as an area. On the 1st of the month the series holds a single day, and an area spanning one point has no width to paint, so the chart rendered as bare axes even though the row above it showed a real number. Show the point marker when only one day carries data, for both the single series and the stacked breakdown. Counter metrics are unaffected: they draw bars, and one day is one visible bar.
Contributor
Preview Deploys
|
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
The old name and its comment claimed a numeric cell always means real data. That holds for a base series, but the breakdown builder zero-fills missing past days, so a row of zeros counted too. What the function actually measures is how many days the chart plots, which is what the single-point check needs either way.
gabrielle-svg
approved these changes
Sep 1, 2026
gabrielle-svg
left a comment
Contributor
There was a problem hiding this comment.
Nice touch on the point marker!
macko911
deleted the
matej/nan-6845-show-usage-on-the-first-day-of-the-month-instead-of-a-blank
branch
September 1, 2026 14:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the 1st of every month the Connections and Sync records charts on
/team/billingrender as bare axes — no data — while the row above them shows a real number. It reads as a broken page, and it fixes itself on the 2nd.The data is there. Those are running-average metrics, drawn as an area, and on the 1st the series holds a single day. An area spanning one point has no width to paint.
Solution
countDaysWithDatanext to the chart-row builders inuseChartData.ts, with unit tests.Counter metrics are unaffected — they draw bars, and one day is one visible bar.
Fixes NAN-6845
Testing
Verified against dev data on Sept 1 (a natural repro): single series, grouped by integration, and August as a no-regression check.