Skip to content

fix(github): add deployment for byoc-gcp-1 - #7461

Merged
rossmcewan merged 3 commits into
masterfrom
ross/20260909/add-deployument-for-byoc-gcp-1
Sep 10, 2026
Merged

fix(github): add deployment for byoc-gcp-1#7461
rossmcewan merged 3 commits into
masterfrom
ross/20260909/add-deployument-for-byoc-gcp-1

Conversation

@rossmcewan

@rossmcewan rossmcewan commented Sep 9, 2026

Copy link
Copy Markdown
Contributor
  • Added new deployment for frontends for BYOC on GCP
  • Explicitly not introducing service deployment - this will be handed via direct GitOps
  • Ignore naming standards for now - ongoing project to align

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 1 file

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread .github/workflows/deploy.yaml
Comment thread .github/workflows/deploy.yaml
Comment thread .github/workflows/deploy.yaml

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed against the latest diff

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread .github/workflows/deploy.yaml
Comment thread .github/workflows/deploy.yaml
@rossmcewan
rossmcewan requested review from a team and pfreixes September 9, 2026 11:57

@pfreixes pfreixes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @rossmcewan Im a bit lost, Who is behind byoc-gcp-1? is this us?

@rossmcewan

Copy link
Copy Markdown
Contributor Author

Sorry @rossmcewan Im a bit lost, Who is behind byoc-gcp-1? is this us?

It's customer. I cannot put non public reference customers in our public repo.

@rossmcewan
rossmcewan added this pull request to the merge queue Sep 10, 2026
Merged via the queue into master with commit 0fc02a1 Sep 10, 2026
45 checks passed
@rossmcewan
rossmcewan deleted the ross/20260909/add-deployument-for-byoc-gcp-1 branch September 10, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants