Skip to content

Capitalization updates - #166

Merged
ppinchuk merged 6 commits into
mainfrom
pp/better_jur_merge
Jun 16, 2025
Merged

Capitalization updates#166
ppinchuk merged 6 commits into
mainfrom
pp/better_jur_merge

Conversation

@ppinchuk

Copy link
Copy Markdown
Collaborator

We can't apply .title() to county and subdivision names, because that converts things like McLean to Mclean. Instead, let's assume that the user properly capitalized those inputs (and add a warning to the docs for users to do so).

@ppinchuk ppinchuk added this to the Solar Validation milestone Jun 16, 2025
@ppinchuk ppinchuk self-assigned this Jun 16, 2025
@ppinchuk ppinchuk added enhancement Update to logic or general code improvements p-medium Priority: medium labels Jun 16, 2025
@ppinchuk
ppinchuk merged commit e0820f6 into main Jun 16, 2025
2 checks passed
@ppinchuk
ppinchuk deleted the pp/better_jur_merge branch June 16, 2025 17:39
github-actions Bot pushed a commit that referenced this pull request Jun 16, 2025
* No title function

* New utility function

* Updated merge logic

* Updated test for correct warning message

* Assume correct capitalization for county and subdivision

* Update tests for capitalization
rajeee pushed a commit that referenced this pull request May 27, 2026
* No title function

* New utility function

* Updated merge logic

* Updated test for correct warning message

* Assume correct capitalization for county and subdivision

* Update tests for capitalization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Update to logic or general code improvements p-medium Priority: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant