Disaggregated heat load inputs and outputs + Process heat load#583
Disaggregated heat load inputs and outputs + Process heat load#583
Conversation
zolanaj
changed the title
|
@zolanaj just making sure this won't affect any existing behavior when using the default |
Confirmed, the defaults for CHP, ExistingBoiler, HotThermalStorage, Boiler, and SteamTurbine can all serve both DHW and space heating by default, which is consistent with the notion that all techs serve all heating loads. The exception is GHP which already had the field HeatingLoad outputs for DHW and SpaceHeating are unchanged. There are new outputs within HeatingLoad related to process heat, but only if included (otherwise it's blank). Will that work or should those be suppressed somehow? |
| )) | ||
|
|
||
| HEATING_LOAD_INPUT = models.TextChoices('HEATING_LOAD_INPUT', ( | ||
| 'DomesitHotWater', |
There was a problem hiding this comment.
Thanks for catching this and the changelog update!
| self.addressable_load_fraction = list([1.0]) # should not convert to timeseries, in case it is to be used with monthly_mmbtu or annual_mmbtu | ||
|
|
||
| class ProcessHeatLoadInputs(BaseModel, models.Model): | ||
| # DHW |
There was a problem hiding this comment.
Is "#DHW" here intentional?
| repo-url = "https://github.com/NREL/REopt.jl.git" | ||
| uuid = "d36ad4e8-d74a-4f7a-ace1-eaea049febf6" | ||
| version = "0.45.0" | ||
| version = "0.46.0" |
There was a problem hiding this comment.
Just a note to update this to the 46.1 eventually
There was a problem hiding this comment.
Thanks for the reminder! Addressed here: ae8fcea
adfarth
left a comment
adfarth
left a comment
There was a problem hiding this comment.
Approved with one very minor comment :)
|
@zolanaj thanks for confirming, that should work. |
3 participants
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
(What changes might users need to make in their application due to this PR?)
None known, but the new I/O requires linkage to v. 0.46.1 of REopt.jl
Other information: