Skip to content

erp outputs endpoint#589

Merged
hdunham merged 10 commits intodevelopfrom
erp-outputs-help
Jul 22, 2024
Merged

erp outputs endpoint#589
hdunham merged 10 commits intodevelopfrom
erp-outputs-help

Conversation

@hdunham
Copy link
Copy Markdown
Collaborator

@hdunham hdunham commented Jul 2, 2024

Please check if the PR fulfills these requirements

  • CHANGELOG.md is updated
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features) will edit wiki once merged into main

What kind of change does this PR introduce?

feature

What is the current behavior?

no erp/inputs (same as erp/help) or erp/outputs urls in the API

What is the new behavior (if this is a feature change)?

erp/inputs (same as erp/help) or erp/outputs urls added

Does this PR introduce a breaking change?

no

Other information:

once merged, update wiki adding
Get descriptions of possible ERP inputs: /erp/inputs?
Get descriptions of possible ERP outputs: /erp/outputs?
here:
https://github.com/NREL/REopt_API/wiki/1.-Structure-of-the-REopt-API#api-endpoints

@hdunham hdunham requested a review from Bill-Becker July 2, 2024 00:25
@Bill-Becker
Copy link
Copy Markdown
Collaborator

@hdunham I tried to spin the API up locally and test the endpoints, but I'm getting a "connection refused" error. The same GET request to the staging and production servers got a good response for the existing /help endpoint. You've tested this locally?

@hdunham
Copy link
Copy Markdown
Collaborator Author

hdunham commented Jul 10, 2024

@hdunham I tried to spin the API up locally and test the endpoints, but I'm getting a "connection refused" error. The same GET request to the staging and production servers got a good response for the existing /help endpoint. You've tested this locally?

That's weird, yeah I did test it locally. Let me look again.

@hdunham hdunham requested a review from adfarth July 18, 2024 15:46
Comment thread CHANGELOG.md
Comment thread resilience_stats/views.py Outdated
Comment thread resilience_stats/views.py
@adfarth
Copy link
Copy Markdown
Collaborator

adfarth commented Jul 18, 2024

@hdunham I tried to spin the API up locally and test the endpoints, but I'm getting a "connection refused" error. The same GET request to the staging and production servers got a good response for the existing /help endpoint. You've tested this locally?

That's weird, yeah I did test it locally. Let me look again.

Oh I guess checking if this ended up working for you when you looked at it again?

@hdunham
Copy link
Copy Markdown
Collaborator Author

hdunham commented Jul 22, 2024

@hdunham I tried to spin the API up locally and test the endpoints, but I'm getting a "connection refused" error. The same GET request to the staging and production servers got a good response for the existing /help endpoint. You've tested this locally?

That's weird, yeah I did test it locally. Let me look again.

Oh I guess checking if this ended up working for you when you looked at it again?

Yeah I've tested it many times and it's always worked

@hdunham hdunham requested a review from adfarth July 22, 2024 17:40
Copy link
Copy Markdown
Collaborator

@adfarth adfarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hdunham approving, but looks like you may need to merge develop one more time to resolve merge conflicts

@hdunham hdunham removed the request for review from Bill-Becker July 22, 2024 19:12
@hdunham hdunham merged commit 9cf84ae into develop Jul 22, 2024
@hdunham hdunham deleted the erp-outputs-help branch July 22, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants