Fix handling of attempt ID in the apps - #97
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the handling of attempt ID throughout the application by adding attempt_id display to tables and updating log file path construction to include the attempt ID component.
Changes:
- Added "Attempt" column to results tables in web dashboard and TUI to display
attempt_id(defaulting to 1) - Updated log file path construction to include
_a{attempt_id}component in the naming convention - Modified result sorting logic to consider both
run_idandattempt_idwhen finding the latest result
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| torc-dash/static/js/app-tables.js | Added "Attempt" column header and display in results table |
| torc-dash/static/js/app-job-details.js | Added "Attempt" column, updated run selector display, and fixed log path construction to include attempt_id |
| torc-dash/static/js/app-details.js | Added attempt_id display in results table body rows |
| tests/test_full_workflows.rs | Updated result sorting to use (run_id, attempt_id) tuple for finding latest result |
| src/tui/ui.rs | Added "Attempt" column to TUI results table with proper column width constraint |
| src/tui/app.rs | Updated result sorting logic and added explanatory comment about sorting by (run_id, attempt_id) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.