Nathan culver#1
Open
Nathan-Culver wants to merge 2 commits into
Open
Conversation
GannonDetroit
left a comment
GannonDetroit
left a comment
Collaborator
There was a problem hiding this comment.
You did a good job but what happened to the given code in the prototype file? How are you missing the swordsman and archer? Without them the console,logs don't run/dont' have the answers.
| @@ -14,15 +14,29 @@ | |||
| * dimensions (These represent the character's size in the video game) | |||
| * takeDamage() // prototype method -> returns the string '<object name> took damage.' | ||
| * should inherit destroy() from GameObject's prototype | ||
| */ | ||
| function CharacterStats (Attributes) { |
| * should inherit takeDamage() from CharacterStats | ||
| */ | ||
|
|
||
| function Humanoid (Attributes) { |
| @@ -102,7 +126,7 @@ | |||
| console.log(archer.greet()); // Lilith offers a greeting in Elvish. | |||
Collaborator
There was a problem hiding this comment.
what happen to the swordsman and archer???
| @@ -102,7 +126,7 @@ | |||
| console.log(archer.greet()); // Lilith offers a greeting in Elvish. | |||
| console.log(mage.takeDamage()); // Bruce took damage. | |||
| console.log(swordsman.destroy()); // Sir Mustachio was removed from the game. | |||
Collaborator
There was a problem hiding this comment.
several of these are not working because you're missing code.
| @@ -1,10 +1,10 @@ | |||
| /* The for principles of "this"; | |||
| * in your own words. explain the four principle for the "this" keyword below. | |||
Collaborator
There was a problem hiding this comment.
very good! short and concise answers that are correct and to the point. Love it.
| @@ -13,14 +13,83 @@ | |||
|
|
|||
| // code example for Window Binding | |||
| sayAge(); | ||
|
|
||
| // Principle 2 | ||
|
|
Collaborator
There was a problem hiding this comment.
good job, I like that you took the time to make multiple examples.
| nathan.josh.sayName(); | ||
| nathan.steven.sayName(); | ||
|
|
||
| // Principle 3 |
|
|
||
| console.log(mike); | ||
|
|
||
| // Principle 4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Init pull