Don't check for pod5/fast5 files#492
Merged
ssjunnebo merged 2 commits intoNationalGenomicsInfrastructure:masterfrom Oct 7, 2025
Merged
Don't check for pod5/fast5 files#492ssjunnebo merged 2 commits intoNationalGenomicsInfrastructure:masterfrom
ssjunnebo merged 2 commits intoNationalGenomicsInfrastructure:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #492 +/- ##
==========================================
- Coverage 26.05% 26.04% -0.02%
==========================================
Files 37 37
Lines 5545 5544 -1
==========================================
- Hits 1445 1444 -1
Misses 4100 4100 ☔ View full report in Codecov by Sentry. |
Member
|
Ah, yes. Anything else we've missed or do you want a review now? |
Author
|
Review please 😄 |
alneberg
approved these changes
Oct 7, 2025
Member
alneberg
left a comment
alneberg
left a comment
There was a problem hiding this comment.
All good. Versions come quickly now.
ssjunnebo
merged commit 7d9d24c
into
NationalGenomicsInfrastructure:master
11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the assert for raw data