Fix missing sequencing_started status#19
Fix missing sequencing_started status#19ssjunnebo merged 2 commits intoNationalGenomicsInfrastructure:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19 +/- ##
=======================================
Coverage 83.68% 83.68%
=======================================
Files 10 10
Lines 527 527
Branches 41 41
=======================================
Hits 441 441
Misses 78 78
Partials 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| f"Run {run_dir} is already marked as sequenced, but transfer not complete. " | ||
| "Will attempt final transfer again." | ||
| ) | ||
| if not run.has_status("sequencing_started"): |
There was a problem hiding this comment.
What happens if final_sync_successful is already true but sequencing_started has not been set? Is that something that can happen?
There was a problem hiding this comment.
That shouldn't happen. run.final_sync_successful is only true if final_rsync_exitcode_file is 0, and that file is only generated if run.start_transfer(final=True) has been run, which only happens if line 48 is true (if not run.final_sync_successful:) which will now set sequencing_started.
alneberg
left a comment
alneberg
left a comment
There was a problem hiding this comment.
I meant to approve it with my previous comment.
ssjunnebo
merged commit a36c9f8
into
NationalGenomicsInfrastructure:master
4 participants
Set sequencing_started if sequencing finished before sequencing_started was set.