feat: nx 23 and angular 22#175
Merged
Merged
Conversation
Squash of the Nx 23.1 migration commits: - checkpoint before running migrations (dependency updates) - 23-0-0-add-migrate-runs-to-git-ignore - change-detection-eager - http-xhr-backend - strict-templates-default - strict-safe-navigation-narrow - update-23-1-0-convert-to-flat-config - update-23-1-0-remove-conflicting-extended-diagnostics Instead of keeping the 23-1-0-add-ignore-deprecations-for-ts6 migration's "ignoreDeprecations": "6.0" suppressions, the TS6-deprecated options are fixed directly: baseUrl removed (paths made explicitly relative), tools target bumped es5 -> es2022, and the esModuleInterop: false pin dropped in favor of the TS6 default. The generated migrations.json and tools/ai-migrations docs are not kept.
@angular/core 22 no longer exports ComponentFactory, so the deprecated loadWithFactory and loadWithFactoryInLocation methods (unused within the repo) are removed. Use the Type<T>-based loaders or Portals instead.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
TS6 deprecates baseUrl (TS5101). The path mappings are already relative, so they resolve identically against the tsconfig directory.
@nativescript/core 9.0.20 uses the iOS 26 interactiveContentPopGestureRecognizer API when running on iOS 26+. Apps built with the iOS 18 SDK (Xcode 16) lack the API in their generated metadata, crashing the test app on the iOS 26.2 simulator. Build with Xcode 26 so the metadata matches the simulator runtime.
NathanWalker
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
The workspace runs on Nx 22 / Angular 21-era tooling with the legacy
.eslintrc.jsonconfig format, and@nativescript/nxis consumed from a local tarball. TheDetachedLoaderstill exposes the deprecatedComponentFactory-based methods (loadWithFactory,loadWithFactoryInLocation), which no longer compile against@angular/core22 sinceComponentFactoryis no longer exported from its public API.What is the new behavior?
nx migratecommits, including the eager change-detection,provideHttpClient(withXhr()), strict-templates-default, and flat ESLint config migrations).ignoreDeprecations: deprecatedbaseUrlremoved (pathsmade explicitly relative), tools tsconfig target bumpedes5→es2022, and theesModuleInterop: falsepin dropped in favor of the TS6 default.ComponentFactory-basedDetachedLoadermethods are removed, fixing the build against@angular/core22.@nativescript/nxnow resolves to the published23.0.0-rc.0from npm instead of a local tarball.BREAKING CHANGES:
DetachedLoader.loadWithFactoryandDetachedLoader.loadWithFactoryInLocationhave been removed.@angular/core22 no longer exportsComponentFactory, so these already-deprecated methods can no longer be supported.Migration steps:
Use the
Type<T>-based equivalents —loadComponent,loadComponentSync, orloadComponentInLocation— passing the component class directly instead of a resolved factory, or preferably migrate to Portals (createComponentPortal).Summary by CodeRabbit
New Features
Bug Fixes
Chores