[DON'T MERGE] Make nativescript-angular modules es6. #548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsndeck
force-pushed
the
nnikolov/Es6Modules
branch
3 times, most recently
from
c7e2884 to
2ce81e8
Compare
hdeshev
changed the title
nsndeck
force-pushed
the
nnikolov/Es6Modules
branch
3 times, most recently
from
cb46686 to
4ab9728
Compare
hdeshev
suggested changes
Dec 7, 2016
nativescript-angular/index.ts
Outdated
| export * from "./router/ns-router-link"; | ||
| export * from "./router/page-router-outlet"; | ||
| export * from "./router/router-extensions"; | ||
| export * from "./parse5_adapter"; |
Contributor
There was a problem hiding this comment.
We should not export parse5_adapter, private_import* as public API here. Maybe we can create a separate "private API" rollup entrypoint?
| @@ -1,12 +1,12 @@ | |||
| var Zone$1 = (function (global) { | |||
| if (global.Zone) { | |||
| throw new Error('Zone already loaded.'); | |||
Contributor
There was a problem hiding this comment.
Let's exclude the zone.js ' -> " transform since it's generated from the Angular code.
nsndeck
force-pushed
the
nnikolov/Es6Modules
branch
from
4ab9728 to
0b2c644
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.