fix: #10 bug: Throws an error if scss-file is empty#12
Merged
toddanglin merged 1 commit intoNativeScript:masterfrom Oct 17, 2016
m-abs:issue-10
Merged
fix: #10 bug: Throws an error if scss-file is empty#12toddanglin merged 1 commit intoNativeScript:masterfrom m-abs:issue-10
toddanglin merged 1 commit intoNativeScript:masterfrom
m-abs:issue-10
Conversation
Contributor
m-abs
commented
Oct 7, 2016
m-abs
commented
- Will no longer throw an error for empty files
- nativescript-angular: ng2 throws errors if css-files doesn't exist, to accommodate that write empty css-files if the sass-file is empty
* Will no longer throw an error for empty files * nativescript-angular: ng2 throws errors if css-files doesn't exist, to accommodate that write empty css-files if the sass-file is empty
Contributor
|
Thanks @m-abs! Change makes sense, though it would be a big change to "standard" behavior/output. @NathanWalker Does this check-out for you, too? If so, I'll merge and update. |
Contributor
|
Very helpful @m-abs - have run into this many times before! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.