feat(tvos): build Apple TV V8 release variants - #8
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
LorenzGit
marked this pull request as ready for review
September 8, 2026 18:44
NathanWalker
added a commit
to NativeScript/ios
that referenced
this pull request
Sep 12, 2026
Same V8 build inputs as -7 plus the arm64-tvdevice and arm64-tvsimulator variants (NativeScript/v8-buildscripts#8), which download_v8.sh --tvos installs for the tvOS runtime build. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
NathanWalker
added a commit
to NativeScript/ios
that referenced
this pull request
Sep 12, 2026
Same V8 build inputs as -7 plus the arm64-tvdevice and arm64-tvsimulator variants (NativeScript/v8-buildscripts#8), which download_v8.sh --tvos installs for the tvOS runtime build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add arm64 tvOS device and simulator release variants to the current V8 source-build matrix. Keep the five existing Apple GN argument sets unchanged.
Validation
Both V8 14.9.207.39 variants built and packaged. Actual isolate.o compiler commands contain -O3 and -DNDEBUG; device object auditing confirms TVOS/minimum 13.0. Both matrix regression tests passed. The resulting archives built and ran the current NativeScript tvOS simulator app.
Reproduce
Revision-pinned reviewer setup builds the companion stack in an isolated workspace. It includes commands, requirements, dependency pins and physical-device limitations. No binary artifacts or private development paths are committed.
This PR contains one commit,
36a75935c032f8ce0715e05ef112a42350d8dce1, changing 4 files against9dfc18bfac6e2c3e49253ab88c68c0a4ae289371. Its exported patch reproduces the committed tree from a fresh base index.The source-built runtime was validated in the prepared runtime checkout; companion clones, native helpers, Canvas and clean npm installation were validated in a separate workspace on the same Mac. A second machine and one uninterrupted cold
allrun have not been tested.