Merge back#1
Closed
radiant-alex wants to merge 743 commits intoNativeScript:masterfrom
radiant-alex:merge_back
Closed
Merge back#1radiant-alex wants to merge 743 commits intoNativeScript:masterfrom radiant-alex:merge_back
radiant-alex wants to merge 743 commits intoNativeScript:masterfrom
radiant-alex:merge_back
Conversation
Clear the close timer only when it could be set.
Use the default value when the HTTP server is created internally.
Move the `isValidErrorCode` function to the Validation module and rename it to `isValidStatusCode`.
This reverts commit 297f56d.
Throw an error if the same `server` option is used for multiple WebSocket servers at the same time.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.