Implement user confirmation for shell_tool command - #16
Merged
Conversation
Added user confirmation before executing shell command. Signed-off-by: Pacsfury <280690649+Pacsfury@users.noreply.github.com>
Owner
|
Please fix the Flake8 line length issue. It would also be nice if you added a NO_COMMAND_CONFIRMATION setting (integer, min 0, max 1) to disable the prompt. |
Signed-off-by: Pacsfury <280690649+Pacsfury@users.noreply.github.com>
Contributor
Author
|
@Natuworkguy fixed! |
Natuworkguy
previously requested changes
Aug 5, 2026
Signed-off-by: Pacsfury <280690649+Pacsfury@users.noreply.github.com>
Contributor
Author
|
Fixed |
Signed-off-by: Nathan C. <149914029+Natuworkguy@users.noreply.github.com>
…l command approval logic
Natuworkguy
approved these changes
Aug 5, 2026
Natuworkguy
left a comment
Natuworkguy
left a comment
Owner
There was a problem hiding this comment.
CI passes, code/behavior looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added user confirmation before executing shell command.
Why this is needed?
Before this change, AI could hallucinate some bad commands like
sudo rm -rf / --no-preserve-rootat Linux.With this change, every command must be verified by the human that decides if to execute it or no.
Possible future changes