.browserslistrc가 없을 때 browserslist에서 발생하는 에러를 해결합니다 - #18
Merged
Conversation
Contributor
✅ Changeset detectedLatest commit: bd756c9
If no version change is needed, please add The changes in this PR will be included in the next version bump. powered by: naverpay changeset detect-add actions |
Contributor
|
우리 browserslistrc 없으면 우리껄로 기본값하기로 했던거같은데 맞나요? |
Contributor
Author
|
https://github.com/NaverPayDev/pite/blob/main/packages/pite/src/index.ts#L3-L29 네넵 그건 반영되어있습니다. �cosmic config관련 로직 실행전에 터져서,, 이부분 수정했씁니다 |
| dep, | ||
| new RegExp(`^${dep}/.*`), | ||
| ]), | ||
| external: [...deps, 'node:path', 'node:fs'], |
Contributor
There was a problem hiding this comment.
keemhyunseok
force-pushed
the
repo/15_cwd
branch
from
December 30, 2024 08:40
be89589 to
29be0bd
Compare
Contributor
Author
|
감삼다~ |
2-one-week
reviewed
Dec 31, 2024
| // @ts-check | ||
| export default createViteConfig({ | ||
| formats: ['es', 'cjs'], | ||
| cwd: '.', |
Member
There was a problem hiding this comment.
이거 주로 __dirname 넣어주긴 하는데, 기본값을 '.' 으로 줄까여
Contributor
Author
There was a problem hiding this comment.
저는 별 생각없이 넣은 것이긴한데 기본값 있어서 옵셔널로 받아도 좋을 것 같습니다
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Describe your changes
const packageJSONPath = path.join(cwd, 'package.json')코드에서 발생하는 에러를 해결합니다Request