Skip to content

feat(koa): Koa 3.x 지원 추가#19

Merged
myamaak merged 2 commits into
mainfrom
feature/koa-v3-support
Jul 13, 2026
Merged

feat(koa): Koa 3.x 지원 추가#19
myamaak merged 2 commits into
mainfrom
feature/koa-v3-support

Conversation

@myamaak

@myamaak myamaak commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

@naverpay/prometheus-koa가 Koa 3.x를 공식 지원하도록 변경했습니다. 기존 2.x 사용자 영향은 없습니다.

  • koa를 peerDependency로 명시 (>=2.0.0 — Koa 2.x/3.x 동시 지원)
  • 타입 검증 기준을 @types/koa 3.x로 상향
  • @types/koa 3.x 상향 시 @koa/router 팩토리 함수의 추론 반환 타입에서 발생하는
    타입 이식성 경고(TS2742)를, 라우터 팩토리 3곳(getKoaMetricsRouter/getNoopRouter/
    getKoaStandaloneMetricsRouter)에 명시적 Router 반환 타입을 달아 해소
  • README 요구 사항 갱신 (Koa 2.x/3.x, Koa 3.x 사용 시 Node.js 18 이상)

미들웨어·라우터가 v2/v3 공통 API만 사용하므로 런타임 로직 변경은 없습니다.
Koa 3.x breaking change(ctx.throw 시그니처, querystring→URLSearchParams,
redirect('back') 제거, generator 미들웨어 제거)는 본 패키지에 해당되지 않음을 확인했습니다.

koa를 peerDependency(>=2.0.0)로 명시해 Koa 2.x/3.x를 함께 지원하고,
타입 검증 기준을 @types/koa 3.x로 상향.
@npayfebot

npayfebot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

✅ Changeset detected

Latest commit: ff0618d

@naverpay/prometheus-koa package have detected changes.

If no version change is needed, please add skip-detect-change to the label.

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@naverpay/prometheus-koa ✨ Minor
powered by: naverpay changeset detect-add actions

@myamaak myamaak self-assigned this Jul 9, 2026
@myamaak
myamaak marked this pull request as ready for review July 9, 2026 05:00

@2-one-week 2-one-week left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감삼닷

@arale-dev arale-dev left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다!

@myamaak
myamaak merged commit ec8c3e2 into main Jul 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants