Skip to content

fix: pnpm 10.33.4로 업그레이드#23

Merged
myamaak merged 2 commits into
mainfrom
repo/fix-release-pnpm-git-checks
Jul 14, 2026
Merged

fix: pnpm 10.33.4로 업그레이드#23
myamaak merged 2 commits into
mainfrom
repo/fix-release-pnpm-git-checks

Conversation

@myamaak

@myamaak myamaak commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Related Issue

Describe your changes

  • tooling/github에 private: true 추가
    • pnpm-workspace.yaml의 tooling/* 글롭에 걸려 changeset publish 대상에 포함됐으나, placeholder 패키지(@naverpay/github@0.0.0)라 배포 의도 없음
  • pnpm을 10.13.1 → 10.33.4로 업그레이드
    • pnpm 10.19.0부터 removePnpmSpecificOptions가 publish 시 --no-git-checks 등 pnpm 전용 플래그를 npm 위임 전에 제거하도록 수정됨
    • 10.13.1은 이 처리가 없어 플래그가 그대로 npm에 전달되고, npm 12에서 unknown flag로 throw되어 EUNKNOWNCONFIG 발생 → 5개 패키지 publish 전체 실패

dayoung-nam added 2 commits July 14, 2026 16:34
tooling/* 글롭에 걸려 changeset publish 대상에 포함됐으나, 설명이 placeholder이고
버전이 0.0.0인 내부용 패키지라 배포 의도가 없음. private 지정으로 배포 대상에서 제외.
pnpm 10.19.0부터 removePnpmSpecificOptions가 publish 시 --no-git-checks 등
pnpm 전용 플래그를 npm 위임 전에 제거함. 10.13.1은 이 처리가 없어 플래그가
그대로 npm에 전달되고, npm 12에서 unknown flag로 throw돼 EUNKNOWNCONFIG
발생. node 22.14.0 + npm 12 dry-run으로 10.13.1 실패/10.33.4 정상 재현 확인.
@npayfebot

Copy link
Copy Markdown
Contributor

🔍 No files have been changed

Latest commit: f921852

Please check your commit.

If packages_dir is not specified or only markdown files are in the changes, detection may fail.

powered by: naverpay changeset detect-add actions

@myamaak
myamaak marked this pull request as ready for review July 14, 2026 08:32

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

Claude Code Review is paused for this repository. To reconnect it, an admin of this repository's GitHub organization (or the account owner, for personal repositories) who can also manage your Claude organization's Code Review settings needs to re-link GitHub in Code Review settings. This is a one-time step.

Tip: disable this comment in your organization's Code Review settings.

@kyungmi kyungmi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이런 이슈도 있군요
private는 혹시 왜 추가된건가요?

pnpm-workspace.yaml의 tooling/* 글롭에 걸려 changeset publish 대상에 포함됐으나, placeholder 패키지(@naverpay/github@0.0.0)라 배포 의도 없음

봤는데 무슨 내용인지 이해를 못했.. ㅠㅠ

아 tooling/* 경로도 패키지 패포 대상으로 잡혀있었군요. 이해함요 ㅋㅋ

@myamaak
myamaak merged commit f3b3de9 into main Jul 14, 2026
4 checks passed
@myamaak
myamaak deleted the repo/fix-release-pnpm-git-checks branch July 14, 2026 08:59
@myamaak

myamaak commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator Author

@kyungmi 님 넵넵 배포 대상으로 잘못 잡혀있길래 겸사겸사 수정해주었습니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants