Feat/forge templates

[NavpreetST]

Task templates, diff view improvements, type contract fixes

Summary by CodeRabbit

• Bug Fixes

  • Improved PR link visibility handling in the Forge Panel to prevent display issues with missing repository information.

• Improvements

  • File expansion states now reset when switching between different tasks for a cleaner viewing experience.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
axis-dash	Ready	Preview, Comment	Jun 11, 2026 10:43am

[coderabbitai]

📝 Walkthrough

Walkthrough

ForgeTaskDetail interface now requires pr_number (nullable) and repo fields. ForgePanel clears expanded file state when task selection changes and tightens the PR link rendering condition to check pr_number !== null explicitly.

Changes

Forge API and Panel Updates

Layer / File(s)	Summary
ForgeTaskDetail interface contract src/lib/api/forgeClient.ts	ForgeTaskDetail switches pr_number and repo from optional to required properties, preserving pr_number's nullable type.
ForgePanel state and rendering updates src/lib/components/ForgePanel.svelte	ForgePanel resets expandedFiles state when task selection changes via a new reactive $effect, and updates the PR anchor render condition to explicitly check pr_number !== null in alignment with the contract change.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• NavpreetST/axis-dash#35: Overlaps in ForgePanel.svelte diff viewer state management and ForgeTaskDetail type modifications.
• NavpreetST/axis-dash#21: Introduced the original ForgeTaskDetail and ForgePanel components; this PR updates their contract and behavior.

Poem

A contract tightened, fields now firm and sure,
null checks explicit, the render path pure,
When tasks are chosen, old files fade away,
the Panel resets—a fresh start each day! 🐰✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'Feat/forge templates' is vague and generic, using only broad category terms without describing specific changes—it does not clarify what templates were added/changed or what the actual improvements entail.	Revise the title to be more specific and descriptive, such as 'Make pr_number and repo required in ForgeTaskDetail' or 'Fix type contracts and improve diff view state management'.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/forge-templates

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/lib/components/ForgePanel.svelte`:
- Around line 106-109: The effect currently only reads $forgeDiffData when
$forgeSelectedId is null, so diff-only updates can be missed; update the $effect
callback to read both $forgeSelectedId and $forgeDiffData unconditionally (for
example by reading them into an array or using the comma operator) so that
expandedFiles is reset whenever either $forgeSelectedId or $forgeDiffData
changes; change the expression in the $effect that references ($forgeSelectedId
?? $forgeDiffData) to a form that explicitly reads both values so expandedFiles
is reliably cleared.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3c3afb12-3b76-42c2-bdca-15bd83cfe630

📥 Commits

Reviewing files that changed from the base of the PR and between da5cba7 and 19bbe43.

📒 Files selected for processing (2)

• src/lib/api/forgeClient.ts
• src/lib/components/ForgePanel.svelte

[coderabbitai]

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🌐 Web query:

In Svelte 5 runes, does $effectdependency tracking include a store read on the right side of?? when the left side is non-null, or is it skipped due to short-circuit evaluation?

💡 Result:

In Svelte 5, $effect dependency tracking is based on runtime evaluation [1][2]. Because reactivity is determined by which reactive values are synchronously read during the execution of the effect function [1][3], dependency tracking follows standard JavaScript execution rules, including short-circuiting behavior [4]. If you use the nullish coalescing operator (??) in an expression like left ?? right, Svelte will skip the read of right if left is non-null [4]. Consequently, right will not be registered as a dependency for that specific execution of the effect [4][5]. If left is non-null, the effect will only depend on left; if left is null or undefined, the effect will depend on both left and right [6]. This dynamic nature means that dependencies are recalculated every time the effect runs [1][7][6]. If you require an effect to always depend on a value regardless of short-circuiting, you must explicitly read that value outside of the short-circuiting expression [4].

Citations:

• 1: https://svelte.dev/docs/svelte/$effect
• 2: https://github.com/sveltejs/svelte/blob/0c7f8151/documentation/docs/02-runes/04-$effect.md
• 3: https://svelte.dev/docs/svelte/$effect/llms.txt
• 4: docs: clarify example on dynamic dependency tracking sveltejs/svelte#13767
• 5: Svelte 5: $effect dependancy not tracked sveltejs/svelte#12743
• 6: https://www.stanza.dev/courses/svelte-5-performance/fine-grained-reactivity/svelte-5-performance-dependency-tracking
• 7: https://svelte.dev/docs/svelte/%24effect

---

Fix $effect dependency tracking for expandedFiles reset (diff-only changes may be missed)

On Line 107, ($forgeSelectedId ?? $forgeDiffData) short-circuits: when $forgeSelectedId is non-null, $forgeDiffData isn’t read, so the $effect won’t re-run for diff-only updates—expandedFiles won’t reset.

Suggested fix

   $effect(() => {
-    void ($forgeSelectedId ?? $forgeDiffData);
+    void $forgeSelectedId;
+    void $forgeDiffData;
     expandedFiles = {};
   });

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	$effect(() => {
	void ($forgeSelectedId ?? $forgeDiffData);
	expandedFiles = {};
	});
	$effect(() => {
	void $forgeSelectedId;
	void $forgeDiffData;
	expandedFiles = {};
	});

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/lib/components/ForgePanel.svelte` around lines 106 - 109, The effect
currently only reads $forgeDiffData when $forgeSelectedId is null, so diff-only
updates can be missed; update the $effect callback to read both $forgeSelectedId
and $forgeDiffData unconditionally (for example by reading them into an array or
using the comma operator) so that expandedFiles is reset whenever either
$forgeSelectedId or $forgeDiffData changes; change the expression in the $effect
that references ($forgeSelectedId ?? $forgeDiffData) to a form that explicitly
reads both values so expandedFiles is reliably cleared.