refactor: extract entitlement entity names to constants

[AchoArnold]

Replace magic strings with exported constants: services.EntityNameMessageSendSchedule and services.EntityNamePhoneAPIKey. This makes it easier to add new entitlement-limited entities and avoids typo risks.

[greptile-apps]

Greptile Summary

This PR extracts two repeated magic strings used in entitlement checks into exported package-level constants in entitlement_service.go, then replaces the inline literals in the two handler files with those constants. No runtime behavior changes.

• entitlement_service.go: Declares EntityNameMessageSendSchedule and EntityNamePhoneAPIKey constants, then updates the entityLimits map keys to use them instead of inline strings.
• message_send_schedule_handler.go / phone_api_key_handler.go: Each swaps one magic-string argument in the entitlementService.Check(...) call for the corresponding exported constant.

Confidence Score: 5/5

Pure rename refactor with no logic changes; the constant values are identical to the original magic strings, so runtime behaviour is unchanged.

Both constant values exactly match the strings they replace, the entityLimits map and both handler call sites are updated consistently, and no residual magic-string usages were found elsewhere in the codebase.

No files require special attention.

Important Files Changed

Filename	Overview
api/pkg/services/entitlement_service.go	Adds two exported string constants and updates entityLimits map keys to use them; no logic changes.
api/pkg/handlers/message_send_schedule_handler.go	Replaces magic string with services.EntityNameMessageSendSchedule in the entitlement check call; functionally identical.
api/pkg/handlers/phone_api_key_handler.go	Replaces magic string with services.EntityNamePhoneAPIKey in the entitlement check call; functionally identical.

Sequence Diagram

sequenceDiagram
    participant H as Handler (Store)
    participant E as EntitlementService.Check
    participant L as entityLimits map

    H->>E: Check(ctx, userID, EntityNameMessageSendSchedule / EntityNamePhoneAPIKey, countFunc)
    E->>L: lookup entityLimits[entityName]
    L-->>E: plan limits (or not found → unlimited)
    E-->>H: "EntitlementCheckResult{Allowed, Message}"

Loading

_{Reviews (1): Last reviewed commit: "refactor: extract entitlement entity nam..." | Re-trigger Greptile}

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric	Results
Complexity	0
Duplication	0

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}