Skip to content

Recharging point & plan revisions#793

Merged
skinkie merged 28 commits intoNeTEx-CEN:nextfrom
nick-knowles:Recharging-Point-&-Plan-revisions
Jun 18, 2025
Merged

Recharging point & plan revisions#793
skinkie merged 28 commits intoNeTEx-CEN:nextfrom
nick-knowles:Recharging-Point-&-Plan-revisions

Conversation

@nick-knowles
Copy link
Contributor

Revisions to ReCHARGING EQUIPMENT PROFIEL and RECHARGING PLAN to address VVS issues

a) Add RECHARGING STATION and RECHARGING BAY

b) Allow a VETRHICEL JOURNEY to indicate a preferred VEHICEL EQUIPMENT PROFILE / RECHARGING EQUIPMENT PROFILE

c) ALlow RECHARGING EQUIPMENT PROFILE to state which VEHICLE RECHARGING EQUIPMENTs it ios compatible to
to state

nick-knowles and others added 4 commits October 26, 2024 16:33
Add RechargiungStation and Recharging Bay entities
Was missing a height  - needed for shelters seats etc
Allow VEHICLE JOURNEY to ref a RECHARHING PROFILE. ALLOW RECHARGING PROFIEL to say which VEHCILE CHARGING EQUIPMENT it is compatibel with.
@Aurige Aurige requested a review from duexw October 28, 2024 13:32
@Aurige Aurige mentioned this pull request Oct 28, 2024
@Aurige Aurige added the needs documentation update The NeTEx document needs to be updated label Oct 28, 2024
Copy link
Collaborator

@duexw duexw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am generally OK with the new elements RechargingStation and RechargingBay - many thanks. By re-using the ParkingGroup, we inherit many elements and properties which apply to commercial car parking, but not to recharging public buses. That may be confusing to implementers. they will have to apply some common sense here.

The "VDV" example needs some adjustment

  1. In VDV, the charging point would not be part of the ServiceJourneyPattern - otherwise you would need different ServiceJourneyPatterns depending on whether you actually recharge on a journey or not. VDV just needs the assignment from the scheduled stop point to the recharging bays which could be used from there. This is obviously possible:
    image
    so that's fine in the model, but not in the example.

  2. Minor issue:
    In the XML example, the ValueSet/values/TypeOfPlug is a copy of TypeOf Point. But PlugType "Bus Stop" is confusing
    I can help with fixing the VDV example if necessary.

@ue71603 ue71603 added this to the netex_2.0 milestone Oct 29, 2024
@ue71603 ue71603 added the change-request Additional feature, discussed withe the group and having a proper Change Requet in Basecamp. label Oct 29, 2024
@Aurige
Copy link
Contributor

Aurige commented Oct 29, 2024

Update of the VDV Example needed (assign recharging point to Scheduled stop point)
@duexw to propose an update example, and confirm that we can update the document.

duexw and others added 2 commits November 18, 2024 20:51
@Aurige
Copy link
Contributor

Aurige commented Nov 19, 2024

@duexw requirement: Link RechargingStep to 1 Block ?

@ue71603
Copy link
Contributor

ue71603 commented Apr 3, 2025

accept situation with ScheduledStopPoints, but doesn't make really sense.

Aurige and others added 8 commits April 29, 2025 15:09
…tEnergy_version.xsd

Co-authored-by: Stefan de Konink <stefan@konink.de>
…ersion.xsd

Co-authored-by: Stefan de Konink <stefan@konink.de>
…upport.xsd

Co-authored-by: Stefan de Konink <stefan@konink.de>
…upport.xsd

Co-authored-by: Stefan de Konink <stefan@konink.de>
…on.xsd

Co-authored-by: Stefan de Konink <stefan@konink.de>
…e issue

issues in NeTEx VDV Example : Mainly due to removal or "order"
…on.xsd

Co-authored-by: Stefan de Konink <stefan@konink.de>
@Aurige
Copy link
Contributor

Aurige commented Apr 29, 2025

I have accepted pending changes, merged next to the branch to get he latest changes (orders), and updated the XML example accordingly

@Aurige
Copy link
Contributor

Aurige commented May 14, 2025

@duexw we really need to merge this one ASAP (I resynchronised it with next to weeks ago, but ongoing accepted PRs generated conflicts again)

@Aurige
Copy link
Contributor

Aurige commented May 23, 2025

merged next again to the branch to get he latest changes (example conflict resolved)

@Aurige Aurige requested a review from duexw May 23, 2025 10:51
Aurige
Aurige previously approved these changes May 23, 2025
Copy link
Contributor

@Aurige Aurige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks Ok for me (usable) and I would be happy to quickly merge it so we have something workable (note that a first version of recharging plan is already in the XSD and in the documentation). Even if this version is not perfect, it was enhanced, improved and this is better than the original first draft.

Co-authored-by: Stefan de Konink <stefan@konink.de>
duexw added 4 commits June 17, 2025 18:19
…ions. Removed unused parking/charging example.
This reverts commit ce849b3.
Following the decision of the workgroup, recharging stations will be
found under SiteFrame/parkings
…o RechargingStep. Needed for VDV 452 compatibility
Copy link
Collaborator

@duexw duexw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed SiteFrame/rechargingStations as decided at the previous meetings. I have also added references from RechargingStep to the RechargingEquipment and RechargingProfile used. The VDV example is adapted. With these changes, the model is basically compatible with VDV 452. I therefore approve of this pull request in its current state.

@skinkie skinkie merged commit a56f57d into NeTEx-CEN:next Jun 18, 2025
@Aurige Aurige added document has been updated NeTEx Document already updated and removed needs documentation update The NeTEx document needs to be updated labels Jul 3, 2025
@Aurige
Copy link
Contributor

Aurige commented Jul 3, 2025

PArt 1 & 2 documents were updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change-request Additional feature, discussed withe the group and having a proper Change Requet in Basecamp. document has been updated NeTEx Document already updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants