Skip to content

Initial commit for displaying shortcuts in all apps list#680

Closed
YoeriNijs wants to merge 3 commits into
Neamar:masterfrom
YoeriNijs:shortcut-support-all-apps-list
Closed

Initial commit for displaying shortcuts in all apps list#680
YoeriNijs wants to merge 3 commits into
Neamar:masterfrom
YoeriNijs:shortcut-support-all-apps-list

Conversation

@YoeriNijs

@YoeriNijs YoeriNijs commented Jul 12, 2017

Copy link
Copy Markdown
Contributor

An initial commit for displaying shortcuts in the all apps list (as proposed by #621). Not all functions are implemented yet, such as the tag displaying functionality (cc @Neamar ).

I don't know how translators can notice that existing values are changed. Maybe one can help me with that. @naofum, perhaps?

@YoeriNijs YoeriNijs mentioned this pull request Jul 12, 2017
@nmitsou

nmitsou commented Jul 12, 2017

Copy link
Copy Markdown
Collaborator

Hi @YoeriNijs can you explain a bit more what this pr is doing?

@ntninja

ntninja commented Jul 12, 2017

Copy link
Copy Markdown
Collaborator

@YoeriNijs: Updated strings are displayed as "strings needing review" in WebLate and (if you opted in) an appropriate e-mail will be dispatched. Don't worry too much about changing existing strings. 😀

@YoeriNijs

YoeriNijs commented Jul 13, 2017

Copy link
Copy Markdown
Contributor Author

Nice to read, @Alexander255.

Well, @nmitsou, with this PR, shortcuts will be displayed in the all apps list. Moreover, it is possible to exclude the shortcuts from KISS. As aforementioned, it is still lacking some functionalities that (other devs) might implement over time.

@Neamar

Neamar commented Dec 9, 2017

Copy link
Copy Markdown
Owner

I was only able to read the code, because sadly my phone got upgraded to Oreo which removes supports for shortcuts (thanks Android devs...) https://developer.android.com/about/versions/oreo/android-8.0-changes.html

Can anyone with an older Android version review and test?

@Neamar

Neamar commented Jan 29, 2018

Copy link
Copy Markdown
Owner

Can't be tested anymore as I don't have nougat anymore :(

I'm going to close as no one was able to test.

@Neamar Neamar closed this Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants