Continued changes for NNF fencing - #22
Merged
Merged
Conversation
Signed-off-by: Nate Thornton <nate.thornton@hpe.com>
NateThornton
requested review from
ajfloeder,
bdevcich,
matthew-richerson and
roehrich-hpe
January 11, 2023 19:56
bdevcich
reviewed
Jan 11, 2023
| |`--systems-uri=[URI]` | The URI of the Systems object. Must be `/redfish/v1/Systems/Node0` | | ||
| |`--ssl-insecure` | Instructs the use of an insecure SSL exchange | | ||
| | `ip=[ADDRESS]` | The IP address or hostname of the HSS controller | | ||
| | `port=[PORT]` | The Port of the HSS controller. Must be `80` | |
Contributor
There was a problem hiding this comment.
should this be port=80 then?
bdevcich
reviewed
Jan 11, 2023
| | `ip=[ADDRESS]` | The IP address or hostname of the HSS controller | | ||
| | `port=[PORT]` | The Port of the HSS controller. Must be `80` | | ||
| | `systems-uri=[URI]` | The URI of the Systems object. Must be `/redfish/v1/Systems/Node0` | | ||
| | `ssl-insecure=[BOOL]` | Instructs the use of an insecure SSL exchange. Must be `true` | |
bdevcich
reviewed
Jan 11, 2023
| import logging | ||
| import atexit | ||
|
|
||
| sys.path.append("@FENCEAGENTSLIBDIR@") |
Contributor
There was a problem hiding this comment.
I think we need a comment here. Does the user need to change this?
Contributor
Author
There was a problem hiding this comment.
Sorry, should have made it more obvious in the PR. This is just a place to stuff my changes so I have a copy if my machine were to crash. The final place will be in the ClusterLabs repo (or a fork), in which case configure/make will handle the string substitution.
bdevcich
reviewed
Jan 11, 2023
| try: | ||
| from kubernetes import client | ||
| except ImportError: | ||
| logging.error("Couldn't import kubernetes.client - not found or not accessible") |
Contributor
There was a problem hiding this comment.
Why handle this one specifically?
Contributor
Author
There was a problem hiding this comment.
Because it has to be manually installed using pip
bdevcich
reviewed
Jan 11, 2023
| } | ||
|
|
||
| def main(): | ||
| atexit.register(atexit_handler) |
Contributor
Author
There was a problem hiding this comment.
It's in fencing.py
bdevcich
reviewed
Jan 11, 2023
| if e.status == 401: | ||
| fail(EC_LOGIN_DENIED) | ||
| elif e.status == 404: | ||
| fail(EC_STATUS) |
Contributor
There was a problem hiding this comment.
could use http.HTTPStatus for these codes
bdevcich
approved these changes
Jan 11, 2023
Signed-off-by: Nate Thornton <nate.thornton@hpe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the readme for
Adds my in-progress fence_nnf.py changes
Adds my notes.md file
Signed-off-by: Nate Thornton nate.thornton@hpe.com