Skip to content

Using a private repository for user containers#69

Merged
roehrich-hpe merged 2 commits into
mainfrom
private-repos
Jun 6, 2023
Merged

Using a private repository for user containers#69
roehrich-hpe merged 2 commits into
mainfrom
private-repos

Conversation

@roehrich-hpe

Copy link
Copy Markdown
Contributor

Document the use of a private repository for a user's containerized application, and the use of ImagePullSecrets to let k8s access that container.

Create a basic NNF User Container doc to create a place to land the above doc.

Document the use of a private repository for a user's containerized
application, and the use of ImagePullSecrets to let k8s access that container.

Create a basic NNF User Container doc to create a place to land the above doc.

Signed-off-by: Dean Roehrich <dean.roehrich@hpe.com>
Comment thread docs/guides/user-containers/readme.md Outdated
Signed-off-by: Dean Roehrich <dean.roehrich@hpe.com>
### Add the Secret to the NNFContainerProfile

The administrator must add an `imagePullSecrets` list to the NNFContainerProfile
resource that was created for this user's containerized application.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add that its being specifically added to the PodSpec

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would belong in the section of the doc that explains the NNFContainerProfile's parts, which doesn't yet exist.

```

Now any user can select this profile in their Workflow by specifying it in a
`#DW container` directive.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the pod will be free from ImagePullBackOff errors.

optional: true
```

Now any user can select this profile in their Workflow by specifying it in a

@behlendorf behlendorf Jun 6, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could access to an NnfContainerProfile be optionally restricted?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't yet have an idea of how that would be done in a k8s-way.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, we have some ideas. I'm going to checkin this PR and write up a separate idea to share.

kind: NnfContainerProfile
metadata:
name: red-rock-slushy
namespace: nnf-system

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be the default namespace?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The profile collection goes in the 'nnf-system' namespace. When the profile is picked, a temporary copy of it will be placed in the 'default' namespace while it is being used.

### About the Example

Each container registry will have its own way of letting its users create tokens to
be used with their repositories. Docker Hub will be used for the private repository in this example, and the user's account on Docker Hub will be "dean".

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the equivalent here a GitHub access token and for GitLab a deploy token?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that looks like the same usage.

@roehrich-hpe
roehrich-hpe merged commit 3e65ee5 into main Jun 6, 2023
@roehrich-hpe
roehrich-hpe deleted the private-repos branch June 6, 2023 15:54
@bdevcich bdevcich mentioned this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants