Using a private repository for user containers - MPI File Utils#72
Merged
Conversation
Show the placement of the imagePullSecrets lists for private MPI container images in the NnfContainerProfile resource. Signed-off-by: Dean Roehrich <dean.roehrich@hpe.com>
Signed-off-by: Dean Roehrich <dean.roehrich@hpe.com>
ajfloeder
reviewed
Jun 7, 2023
Signed-off-by: Dean Roehrich <dean.roehrich@hpe.com>
ajfloeder
approved these changes
Jun 7, 2023
bdevcich
reviewed
Jun 7, 2023
bdevcich
reviewed
Jun 7, 2023
| #DW container profile=red-rock-slushy [...] | ||
| ``` | ||
|
|
||
| ### Using a Private Version of MPI File Utils |
Contributor
There was a problem hiding this comment.
I would title this Using Private Image Repositories. See my comment below.
Contributor
Author
There was a problem hiding this comment.
No, that heading is used above. This new section is specifically about the adding the imagePullSecrets lists to the mpiSpec in the NnfContainerProfile.
Contributor
There was a problem hiding this comment.
Whoops. I would then just title these sections as Adding Secrets for Non-MPI/MPI Containers or something to that affect.
Contributor
Author
There was a problem hiding this comment.
I think I have it right.
Contributor
|
Thanks for adding this! |
roehrich-hpe
force-pushed
the
restricted-profile
branch
from
June 7, 2023 17:28
56805ce to
9429fee
Compare
Signed-off-by: Dean Roehrich <dean.roehrich@hpe.com>
Contributor
Author
|
Wow, today there is a long delay before new commits appear in the PR. |
Contributor
Author
|
Okay, the PR shows all of my latest updates. |
Signed-off-by: Dean Roehrich <dean.roehrich@hpe.com>
bdevcich
approved these changes
Jun 7, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show the placement of the imagePullSecrets lists for private MPI container images in the NnfContainerProfile resource.