feat: Format profiling, VBA, tables, data utils, sheet views

[Nebu1eto]

Summary

Phase A delivers 6 new feature groups that close critical gaps vs SheetJS/excelize:

• Workbook Format Profiling (A1): WorkbookFormat enum (xlsx/xlsm/xltx/xltm/xlam), auto-detection on open, correct content type on save
• VBA Preservation (A2): Transparent round-trip of vbaProject.bin for macro-enabled files
• Extension-Based Save (A3): save() infers target format from file extension, rejects unsupported extensions
• Data Conversion Utilities (A4): toJSON, toCSV, toHTML, fromJSON helpers (Node.js)
• Full Table CRUD (A5): addTable, getTables, deleteTable with OOXML relationship/content-type wiring
• Sheet View + Visibility (A6): setSheetViewOptions, getSheetViewOptions, setSheetVisibility, getSheetVisibility

Test Coverage

• 1521 Rust tests (1325 core + 183 xml + 7 integration + 6 doc-tests) - all passing
• 321 Node.js tests (6 test files) - all passing
• New tests per feature: A1 (8), A2 (7), A3 (17), A4 (47), A5 (38), A6 (~49), Integration (17)

Commits

Commit	Description
6574a3b	WorkbookFormat enum for OOXML format profiling
255e5fa	VBA project blob round-trip preservation
fe55d48	Extension-based save format inference
0395635	toJSON, toCSV, toHTML, fromJSON conversion helpers
c2fa48d	Full OOXML table CRUD with rel/content-type wiring
bb8ee2b	Sheet view options and sheet visibility APIs
f857577	Node.js bindings for format and table CRUD + integration tests
3a73b68	EN/KO documentation for all Phase A features

Documentation

• 16 doc files updated (8 EN + 8 KO)
• API reference and user guide sections for all features
• ~1460 lines of documentation added

Verification

• cargo build --workspace
• cargo test --workspace (1521 tests)
• cargo clippy --workspace (no warnings)
• cargo fmt --check
• pnpm build (napi + typecheck + tsdown)
• pnpm test (321 tests)

Test plan

• Verify format detection with real .xlsm/.xltx/.xltm/.xlam files
• Verify VBA macro preservation with actual macro-enabled workbooks
• Test table creation and round-trip with Excel/LibreOffice
• Verify data conversion helpers with edge cases
• Test sheet visibility states in Excel

🤖 Generated with Claude Code

[claude]

Code Review

Found 2 issues that need attention:

1. Korean Comments in Documentation Code Blocks (CLAUDE.md Violation)

Korean comments appear in code blocks within Korean documentation. According to CLAUDE.md line 64:

Documentation prose may be in other languages (e.g., Korean guide), but all code blocks within documentation must use English.

Examples:

• // 눈금선 숨기고 확대/축소를 150%로 설정 in docs/ko/guide/advanced.md:941
• // 테이블 목록 조회 in docs/ko/guide/data-features.md

Files affected:

• docs/ko/guide/advanced.md
• docs/ko/guide/data-features.md

Fix: Replace all Korean comments in code blocks with English equivalents.

Reference:

sheetkit/CLAUDE.md

Line 64 in 3a73b68

- Documentation prose may be in other languages (e.g., Korean guide), but all code blocks within documentation must use English.

---

2. Table Path Collision Bug (Critical)

The table ZIP path computation uses self.tables.len() + 1, which can cause path collisions after table deletion.

Location: crates/sheetkit-core/src/workbook/features.rs:123

Reproduction:

1. Add table1 (path = xl/tables/table1.xml)
2. Add table2 (path = xl/tables/table2.xml)
3. Delete table1 (Vec shrinks to 1 entry)
4. Add table3 - self.tables.len() is 1, so table_num = 2, giving path xl/tables/table2.xml (collision!)

This causes ZIP entry collision and data corruption when saving.

Suggested fix: Use monotonically increasing path numbers similar to table_id computation.

Reference:

sheetkit/crates/sheetkit-core/src/workbook/features.rs

Lines 120 to 126 in 3a73b68

	// Assign a unique table ID (max existing + 1).
	let table_id = self.tables.iter().map(|(_, t, _)| t.id).max().unwrap_or(0) + 1;
	let table_num = self.tables.len() + 1;
	let table_path = format!("xl/tables/table{}.xml", table_num);
	let table_xml = crate::table::build_table_xml(config, table_id);

[Nebu1eto]

I reviewed the Phase A workstream branches (dev/phase-a-format-vba, dev/phase-a-data-utils, dev/phase-a-tables, dev/phase-a-sheet-view, and the merged dev/phase-a-integration) and ran focused local repro/tests.

Findings (ordered by severity):

1. [P1] Table part path reuse can break save with duplicate ZIP entries.

• Code path: crates/sheetkit-core/src/workbook/features.rs (table_num = self.tables.len() + 1).
• If you add 2 tables, delete one, then add another table, the new table can reuse an existing xl/tables/tableN.xml path.
• Repro (JS): add T1, add T2, delete T1, add T3, then save -> ZIP error: invalid Zip archive: Duplicate filename.

2. [P1] Deleting a table after reopen can leave dangling tableParts in worksheet XML.

• Save path writes <tableParts> when self.tables had entries, but if tables are removed later the existing worksheet table_parts field is not explicitly cleared when serializing the no-extras path.
• Repro: save workbook with a table -> reopen -> delete table -> save again. Resulting sheet1.xml still contains <tableParts count="1"><tablePart r:id="rId1"/></tableParts> while sheet1.xml.rels has no table relationship and there is no table part.

3. [P1] Node CI is currently failing due formatting issues.

• PR check status shows Node job failing.
• Failure is from pnpm check / Biome formatting in:
  • packages/sheetkit/index.ts
  • packages/sheetkit/__test__/index.spec.ts

4. [P2] fromJSON drops keys that only appear in later records.

• Code path: packages/sheetkit/index.ts (keys = Object.keys(data[0])).
• Repro: fromJSON('Sheet1', [{ A: 1 }, { B: 2 }]) then toJSON('Sheet1') -> second-row B is lost.

5. [P2] setSheetVisibility silently accepts invalid strings and can unexpectedly reset visibility to visible.

• Code path: packages/sheetkit/src/lib.rs maps unknown strings to SheetVisibility::Visible.
• Repro: set hidden, then call setSheetVisibility('Sheet1', 'hiddden-typo') -> sheet becomes visible.

6. [P3] ToHtmlOptions.includeStyles is publicly exposed but not implemented.

• API surface includes includeStyles?: boolean, but toHTML currently ignores it.

Branch-level summary:

• dev/phase-a-format-vba: no blocking findings in my review.
• dev/phase-a-data-utils: good feature coverage, but has CI format failure + fromJSON key-union gap + unused includeStyles option.
• dev/phase-a-tables: contains two blocking issues (1 and 2 above).
• dev/phase-a-sheet-view: mostly solid, but invalid visibility input handling should be strict.
• dev/phase-a-integration: integrates all features, but currently carries the above unresolved issues.

If helpful, I can follow up with concrete patch suggestions for each item.